Repository navigation
[engine] Fix remaining unawaited_futures lints - #193508
Conversation
Resolves the remaining `unawaited_futures` lints in `engine/src/flutter/` after `unawaited_futures` was enabled in `analysis_options_common.yaml` (flutter#193125).
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates several Dart files to properly handle asynchronous operations by adding missing await keywords to futures and wrapping unawaited asynchronous calls in unawaited. The review feedback suggests avoiding the mixture of await and Future.then in shell_test.dart to align with style guidelines. Additionally, for main.dart, the feedback notes that wrapping Stream.pipe on standard I/O streams in unawaited can cause race conditions and close the sinks prematurely, recommending instead to use stdout.addStream and await both streams.
bkonyi
added
autosubmit
|
Detected the If you add the The "Merge" button is also unlocked. To bypass presubmits as well as the tree status, press the GitHub "Add to Merge Queue". |
jtmcdole
left a comment
jtmcdole
left a comment
There was a problem hiding this comment.
I had two comments, but if the tests pass, great.
|
auto label is removed for flutter/flutter/193508, Failed to enqueue flutter/flutter/193508 with HTTP 400: Pull request has failing required statuses and Pull request Required status check "Google testing" is failing.. |
auto-submit
Bot
removed
the
autosubmit
flutter-dashboard
Bot
removed
the
autosubmit
flutter/flutter@c5a061b...55b8f88 2026-09-29 [email protected] [Android 17] Added Android 17 device to Firebase tests (flutter/flutter#193251) 2026-09-29 [email protected] [engine] Fix remaining `unawaited_futures` lints (flutter/flutter#193508) 2026-09-29 [email protected] shell: Rename first-frame tests AddFirstFrameCallback* (flutter/flutter#193418) 2026-09-28 [email protected] Enable `unawaited_futures` lint across the Flutter repository (flutter/flutter#193125) 2026-09-28 [email protected] Upgrade flutter/flutter to Roblectric 4.17 (flutter/flutter#193369) 2026-09-28 [email protected] [engine] Decode animation frames with alpha after an opaque first frame (flutter/flutter#193113) 2026-09-28 [email protected] Allow macOS tests to use macOS 15 or 26 (flutter/flutter#193317) 2026-09-28 [email protected] Cleanup DDC SDK build targets (flutter/flutter#193193) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
3 participants
Resolves the remaining
unawaited_futureslints inengine/src/flutter/afterunawaited_futureswas enabled inanalysis_options_common.yaml(#193125).Part of #168555
Pre-launch Checklist
///).