Repository navigation
Add support for ImageStreamListener.onChunk() - #33092
Merged
Merged
Conversation
This is another step towards supporting image loading progress notification at the widgets layer. This adds an `ImageChunkEvent` class along with associated `ImageChunkListener` callback signature and an `onChunk` property to `ImageStreamListener`. The events serve to notify registered listeners when byte chunks are received while loading an image. #32374
goderbauer
reviewed
May 21, 2019
goderbauer
reviewed
May 21, 2019
8 of 9 tasks
tvolkert
added a commit
that referenced
this pull request
May 23, 2019
I forgot to add `onChunk` to them in #33092
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is another step towards supporting image loading
progress notification at the widgets layer.
This adds an
ImageChunkEventclass along with associatedImageChunkListenercallback signature and anonChunkproperty to
ImageStreamListener. The events serve tonotify registered listeners when byte chunks are received
while loading an image.
Related Issues
#32374
Tests
I added the following tests:
MultiFrameImageStreamCompleterdelivers chunk events to listenersMultiFrameImageStreamCompleterdrops chunk events on the floor before listeners are registered (intended behavior).MultiFrameImageStreamCompleterare properly reported.Checklist
///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?