Skip to content

Fix ImageStreamListener's hashCode & operator== - #33217

Merged
tvolkert merged 1 commit into
flutter:masterfrom
tvolkert:fix_imagestreamlistener
May 23, 2019
Merged

Fix ImageStreamListener's hashCode & operator==#33217
tvolkert merged 1 commit into
flutter:masterfrom
tvolkert:fix_imagestreamlistener

Conversation

@tvolkert

@tvolkert tvolkert commented May 22, 2019

Copy link
Copy Markdown
Contributor

Description

I forgot to add onChunk to ImageStreamListener's hashCode & operator== in #33092

Related Issues

#32374

Tests

  • Verification of equals and hashCode

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read [Handling breaking changes]). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@tvolkert
Fix ImageStreamListener's hashCode & operator==
6efd7d1 
I forgot to add `onChunk` to them in #33092
@tvolkert
tvolkert requested a review from goderbauer May 22, 2019 20:55
@jamesderlin

jamesderlin commented May 23, 2019

Copy link
Copy Markdown
Contributor

I had just been wondering why operator == and hashCode ignored onChunk. LGTM.

@tvolkert
tvolkert merged commit be2918f into flutter:master May 23, 2019
@tvolkert
tvolkert deleted the fix_imagestreamlistener branch May 23, 2019 01:14
@stereotype441 stereotype441 mentioned this pull request May 23, 2019
Merged
8 of 9 tasks
stereotype441 added a commit that referenced this pull request May 23, 2019
@stereotype441
Pass an async callback to testWidgets. (#33260)
9a16900 
The dart analyzer fails to warn about missing returns in function expressions due to a bug that has been
fixed but not yet rolled into Flutter (see
https://dart-review.googlesource.com/c/sdk/+/100301).  So it failed to catch that #33217 accidentally introduced a call to `testWidgets` that passed it a synchronous callback.
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@goderbauer goderbauer Awaiting requested review from goderbauer

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tvolkert @jamesderlin @googlebot