Repository navigation
More removing of timeouts. - #33932
Merged
Merged
Conversation
Contributor
Author
|
cc @tvolkert |
Contributor
Author
Piinks
added
a: tests
tvolkert
reviewed
Jun 6, 2019
Contributor
There was a problem hiding this comment.
Nit: "Image could not be encoded"
Contributor
There was a problem hiding this comment.
Oh n/m - this is going to be appended to the matcher's failure reason, preceded by a "which" isn't it?
Contributor
Author
There was a problem hiding this comment.
I'm guessing yes? The code was inconsistent before, I made it all use this style.
tvolkert
approved these changes
Jun 6, 2019
Contributor
Author
Contributor
Author
|
I negotiated myself to 10 minutes being the default timeout. Attempted to update the API docs and so forth. PTAL. |
tango5614
added a commit
to tango5614/flutter
that referenced
this pull request
Jun 13, 2019
* master: More removing of timeouts. (flutter#33932) Update flakiness of tests (flutter#34374) Roll engine 67aadb6..209250d (4 commits) (flutter#34370) Don't show scrollbar if there isn't enough content (flutter#34175)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #33931 and #18507.