Repository navigation
Don't show scrollbar if there isn't enough content - #34175
Merged
LongCatIsLooong merged 3 commits intoJun 13, 2019
Merged
LongCatIsLooong merged 3 commits into
LongCatIsLooong merged 3 commits into
Conversation
LongCatIsLooong
added
framework
Piinks
approved these changes
Jun 11, 2019
Piinks
reviewed
Jun 11, 2019
Piinks
left a comment
Piinks
left a comment
Contributor
There was a problem hiding this comment.
It looks like this test here is unhappy:
The test seems to expect a scrollbar here, but it appears the container isn't large enough to warrant one with this change. I think the test may need to be changed to reflect the new expected behavior.
tango5614
added a commit
to tango5614/flutter
that referenced
this pull request
Jun 13, 2019
* master: More removing of timeouts. (flutter#33932) Update flakiness of tests (flutter#34374) Roll engine 67aadb6..209250d (4 commits) (flutter#34370) Don't show scrollbar if there isn't enough content (flutter#34175)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Don't show scrollbar if there isn't enough content for both material and cupertino.
Related Issues
Fixes #33635
Tests
I added the following tests:
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?