Skip to content

Increase template Swift version from 4 to 5 - #41882

Merged
jmagman merged 2 commits into
flutter:masterfrom
jmagman:swift-5
Oct 15, 2019
Merged

Increase template Swift version from 4 to 5#41882
jmagman merged 2 commits into
flutter:masterfrom
jmagman:swift-5

Conversation

@jmagman

@jmagman jmagman commented Oct 3, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

Description

Template SWIFT_VERSION from 4.0 to 5.0.

Related Issues

Fixes #40400.

Tests

Updated xcode_test.

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

  • Yes, this is a breaking change (Please read [Handling breaking changes]). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@fluttergithubbot fluttergithubbot added d: examples Sample code and demos c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Oct 3, 2019
@jmagman

jmagman commented Oct 3, 2019

Copy link
Copy Markdown
Member Author

Blocked by #39921.

@jmagman jmagman added platform-macos Building on or for macOS specifically platform-ios iOS applications specifically labels Oct 3, 2019
@jmagman jmagman changed the title Increase template Swift version from 4 to 5 WIP Increase template Swift version from 4 to 5 Oct 3, 2019
@jmagman
jmagman force-pushed the swift-5 branch 2 times, most recently from a0467d2 to b55f46c Compare October 4, 2019 01:34
@jmagman

jmagman commented Oct 4, 2019

Copy link
Copy Markdown
Member Author

This needs to be split into two PRs - one to up the Xcode version (blocked on #39921) and another to increase the Swift version.

@codecov

codecov Bot commented Oct 4, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #41882 into master will decrease coverage by 0.36%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #41882      +/-   ##
==========================================
- Coverage   60.64%   60.27%   -0.37%     
==========================================
  Files         194      194              
  Lines       18877    18877              
==========================================
- Hits        11448    11379      -69     
- Misses       7429     7498      +69
Flag Coverage Δ
#flutter_tool 60.27% <ø> (-0.37%) ⬇️
Impacted Files Coverage Δ
...lutter_tools/lib/src/build_system/targets/web.dart 22.41% <0%> (-29.32%) ⬇️
...ckages/flutter_tools/lib/src/commands/channel.dart 44.61% <0%> (-27.7%) ⬇️
packages/flutter_tools/lib/src/device.dart 45.78% <0%> (-21.09%) ⬇️
packages/flutter_tools/lib/src/base/terminal.dart 77.92% <0%> (-3.9%) ⬇️
packages/flutter_tools/lib/src/version.dart 91.3% <0%> (-3.87%) ⬇️
...ckages/flutter_tools/lib/src/base/file_system.dart 66.66% <0%> (-1.86%) ⬇️
packages/flutter_tools/lib/src/artifacts.dart 70% <0%> (-1.38%) ⬇️
packages/flutter_tools/lib/src/cache.dart 48% <0%> (-1.18%) ⬇️
...utter_tools/lib/src/build_runner/build_script.dart 38.88% <0%> (ø) ⬆️
packages/flutter_tools/lib/src/base/build.dart 74.38% <0%> (+15.7%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13a1b1e...48c38ae. Read the comment docs.

@jmagman

jmagman commented Oct 8, 2019

Copy link
Copy Markdown
Member Author

I split this out from #42254. That will need to be merged first.

@jmagman jmagman changed the title WIP Increase template Swift version from 4 to 5 Increase template Swift version from 4 to 5 Oct 8, 2019
@jmagman
jmagman marked this pull request as ready for review October 8, 2019 19:28
@jmagman
jmagman requested review from cbracken and dnfield October 8, 2019 19:31
dnfield
dnfield approved these changes Oct 8, 2019
View reviewed changes

@dnfield dnfield left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM provided devicelab is ready - and if it is maybe I can reland some patches to enable bitcode?

/cc @digiter

@jmagman

jmagman commented Oct 8, 2019

Copy link
Copy Markdown
Member Author

LGTM provided devicelab is ready - and if it is maybe I can reland some patches to enable bitcode?

/cc @digiter

No, it's not ready, still blocked on #39921. @digiter was estimating it would be done this week. I wanted something to merge ready when the lab is go.

@digiter

digiter commented Oct 12, 2019

Copy link
Copy Markdown
Contributor

Mac machines in devicelab are using Xcode 11.0 now.

@jmagman
jmagman merged commit dda74a1 into flutter:master Oct 15, 2019
@jmagman
jmagman deleted the swift-5 branch October 15, 2019 19:37
Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Nov 26, 2019
@jmagman @Inconnu08
Increase template Swift version from 4 to 5 (flutter#41882)
f7bec90
@jmagman jmagman mentioned this pull request Mar 11, 2020
Closed
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cbracken cbracken Awaiting requested review from cbracken
1 more reviewer
@dnfield dnfield dnfield approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. d: examples Sample code and demos platform-ios iOS applications specifically platform-macos Building on or for macOS specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Swift template is using Swift 4

5 participants

@jmagman @digiter @dnfield @googlebot @fluttergithubbot