Skip to content

Bring back paste button hide behavior - #56689

Merged
justinmc merged 2 commits into
flutter:masterfrom
justinmc:pasteable-revert-revert
May 8, 2020
Merged

justinmc merged 2 commits into
flutter:masterfrom
justinmc:pasteable-revert-revert

Conversation

@justinmc

@justinmc justinmc commented May 8, 2020 •

Copy link
Copy Markdown
Contributor

#54902 was reverted by #56614 because it caused an integration test to fail after it was merged. This brings it back.

The only change is to update the android_semantics_test integration test to include a case with/without content on the clipboard.

@justinmc justinmc self-assigned this May 8, 2020
@fluttergithubbot fluttergithubbot added p: cupertino_ui cupertino_ui package in flutter/packages p: material_ui material_ui package in flutter/packages framework flutter/packages/flutter repository. See also f: labels. labels May 8, 2020
@justinmc
justinmc requested a review from goderbauer May 8, 2020 18:24
@fluttergithubbot fluttergithubbot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) c: contributor-productivity Team-specific productivity, code health, technical debt. labels May 8, 2020

@goderbauer goderbauer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Gotta say, it makes me happy that we have an integration test that caught this! (@jonahwilliams 🎉)

@justinmc
justinmc merged commit d563498 into flutter:master May 8, 2020
@justinmc
justinmc deleted the pasteable-revert-revert branch May 8, 2020 20:41
mehmetf added a commit that referenced this pull request May 10, 2020
mehmetf added a commit that referenced this pull request May 10, 2020
justinmc added a commit to justinmc/flutter that referenced this pull request May 11, 2020
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels. p: cupertino_ui cupertino_ui package in flutter/packages p: material_ui material_ui package in flutter/packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants