Skip to content

Revert "Bring back paste button hide behavior" - #56806

Merged
mehmetf merged 1 commit into
masterfrom
revert-56689-pasteable-revert-revert
May 10, 2020
Merged

Revert "Bring back paste button hide behavior"#56806
mehmetf merged 1 commit into
masterfrom
revert-56689-pasteable-revert-revert

Conversation

@mehmetf

@mehmetf mehmetf commented May 10, 2020

Copy link
Copy Markdown
Contributor

Reverts #56689.

This broke many widget tests in g3 with:

A ClipboardStatusNotifier was used after being disposed.
Once you have called dispose() on a ClipboardStatusNotifier, it
can no longer be used.

Justin will investigate next week. Till then, let's revert.

@fluttergithubbot fluttergithubbot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) p: cupertino_ui cupertino_ui package in flutter/packages p: material_ui material_ui package in flutter/packages framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels May 10, 2020
@mehmetf

mehmetf commented May 10, 2020

Copy link
Copy Markdown
Contributor Author

TBR @justinmc

@mehmetf
mehmetf merged commit 0786f29 into master May 10, 2020
@mehmetf
mehmetf deleted the revert-56689-pasteable-revert-revert branch May 10, 2020 03:22
justinmc added a commit to justinmc/flutter that referenced this pull request May 11, 2020
@justinmc
Revert "Revert "Bring back paste button hide behavior (flutter#56689)" (
23f1aca 
flutter#56806)"

This reverts commit 0786f29.
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels. p: cupertino_ui cupertino_ui package in flutter/packages p: material_ui material_ui package in flutter/packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mehmetf @googlebot @fluttergithubbot