Repository navigation
Changed progress indicator to use drawArc. - #5828
Merged
Merged
Conversation
Contributor
Author
|
Will fail until flutter-team-archive/engine#2995 is merged and the engine rolled. |
Contributor
There was a problem hiding this comment.
please do not check in commented-out code
Contributor
Author
There was a problem hiding this comment.
@Hixie Definitely not! This PR is just groundwork until I roll the engine. (which should happen soon)
Using paths' arcTo was causing performance issues in the Gallery. This commit uses Skia's optimized drawArc in order to improve performance, and it rolls the engine to the newest assing build. Fixes #3599. Tracking Skia issue: https://bugs.chromium.org/p/skia/issues/detail?id=5227
Contributor
|
lgtm |
liyuqian
added a commit
to liyuqian/flutter
that referenced
this pull request
Jul 24, 2018
95e91e3 Update tonic to pull in Android build fixes. (flutter#5834) 29f475c Update tonic to pull in fixes to assertions and build failures on Windows. (flutter#5833) 5474415 Roll src/third_party/skia e35055f31c7f..b8eeb808d84f (5 commits) (flutter#5832) 380eb84 Remove unused function CreateSkiaInterface (flutter#5812) 33a4aef Fix build break caused by flutter-team-archive/engine#5830 (flutter#5831) 244ebd6 Reapply "Fix Dart 2 reload when running from a snapshot instead of platform.dill." (flutter#5830) 0bad812 Migrate to a standalone Tonic repository separated from Topaz (flutter#5817) f949f7d Roll src/third_party/skia 206dbe8a21b6..e35055f31c7f (1 commits) (flutter#5829) 768daa4 Roll src/third_party/skia 5e6cd2affe41..206dbe8a21b6 (5 commits) (flutter#5828) b8cd25b libtxt: fix a bug that used incorrect buffer size depending on conditions (flutter#5804) b7b13b5 Roll src/third_party/skia df795638b9bd..5e6cd2affe41 (1 commits) (flutter#5824) 5886949 Roll src/third_party/skia dfe1fe40796e..df795638b9bd (1 commits) (flutter#5822) 926f546 Roll src/third_party/skia cc22d4d2fb02..dfe1fe40796e (1 commits) (flutter#5821) 04633f3 Generate process global trace identifiers for pipeline flow traces. (flutter#5818) fb0bc05 Roll src/third_party/skia 6f6de6524c73..cc22d4d2fb02 (1 commits) (flutter#5820) fadfff7 Mention that running git clone isn't necessary (flutter#5816) 81ec600 Roll src/third_party/skia d3509a42638a..6f6de6524c73 (5 commits) (flutter#5819) 2a77a41 Make git diff range more robust in format.sh (flutter#5813) e555ea5 Remove trailing white spaces (flutter#5734) 4c7618a Roll src/third_party/skia fa0720436319..d3509a42638a (7 commits) (flutter#5814)
liyuqian
added a commit
that referenced
this pull request
Jul 24, 2018
95e91e3 Update tonic to pull in Android build fixes. (#5834) 29f475c Update tonic to pull in fixes to assertions and build failures on Windows. (#5833) 5474415 Roll src/third_party/skia e35055f31c7f..b8eeb808d84f (5 commits) (#5832) 380eb84 Remove unused function CreateSkiaInterface (#5812) 33a4aef Fix build break caused by flutter-team-archive/engine#5830 (#5831) 244ebd6 Reapply "Fix Dart 2 reload when running from a snapshot instead of platform.dill." (#5830) 0bad812 Migrate to a standalone Tonic repository separated from Topaz (#5817) f949f7d Roll src/third_party/skia 206dbe8a21b6..e35055f31c7f (1 commits) (#5829) 768daa4 Roll src/third_party/skia 5e6cd2affe41..206dbe8a21b6 (5 commits) (#5828) b8cd25b libtxt: fix a bug that used incorrect buffer size depending on conditions (#5804) b7b13b5 Roll src/third_party/skia df795638b9bd..5e6cd2affe41 (1 commits) (#5824) 5886949 Roll src/third_party/skia dfe1fe40796e..df795638b9bd (1 commits) (#5822) 926f546 Roll src/third_party/skia cc22d4d2fb02..dfe1fe40796e (1 commits) (#5821) 04633f3 Generate process global trace identifiers for pipeline flow traces. (#5818) fb0bc05 Roll src/third_party/skia 6f6de6524c73..cc22d4d2fb02 (1 commits) (#5820) fadfff7 Mention that running git clone isn't necessary (#5816) 81ec600 Roll src/third_party/skia d3509a42638a..6f6de6524c73 (5 commits) (#5819) 2a77a41 Make git diff range more robust in format.sh (#5813) e555ea5 Remove trailing white spaces (#5734) 4c7618a Roll src/third_party/skia fa0720436319..d3509a42638a (7 commits) (#5814)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using paths' arcTo was causing performance issues in the Gallery.
This commit uses Skia's optimized drawArc in order to improve
performance. Fixes #3599.
Tracking Skia issue:
https://bugs.chromium.org/p/skia/issues/detail?id=5227