Skip to content

Improve docs for ComponentElement - #5829

Merged
abarth merged 1 commit into
flutter:masterfrom
abarth:component_element_docs
Sep 15, 2016
Merged

abarth merged 1 commit into
flutter:masterfrom
abarth:component_element_docs

Conversation

@abarth

@abarth abarth commented Sep 12, 2016

Copy link
Copy Markdown
Contributor

Also, make ProxyWidget and ProxyElement public.

Fixes #4505

@abarth

abarth commented Sep 12, 2016

Copy link
Copy Markdown
Contributor Author

@Hixie

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and

@Hixie

Hixie commented Sep 12, 2016

Copy link
Copy Markdown
Contributor

LGTM

Also, make ProxyWidget and ProxyElement public.

Fixes flutter#4505
@abarth
abarth force-pushed the component_element_docs branch from 9f6ba80 to 89b5397 Compare September 12, 2016 22:09
@abarth
abarth merged commit 9109bb0 into flutter:master Sep 15, 2016
@abarth
abarth deleted the component_element_docs branch September 15, 2016 16:15
liyuqian added a commit to liyuqian/flutter that referenced this pull request Jul 24, 2018
95e91e3 Update tonic to pull in Android build fixes. (flutter#5834)
29f475c Update tonic to pull in fixes to assertions and build failures on Windows. (flutter#5833)
5474415 Roll src/third_party/skia e35055f31c7f..b8eeb808d84f (5 commits) (flutter#5832)
380eb84 Remove unused function CreateSkiaInterface (flutter#5812)
33a4aef Fix build break caused by flutter-team-archive/engine#5830 (flutter#5831)
244ebd6 Reapply "Fix Dart 2 reload when running from a snapshot instead of platform.dill." (flutter#5830)
0bad812 Migrate to a standalone Tonic repository separated from Topaz (flutter#5817)
f949f7d Roll src/third_party/skia 206dbe8a21b6..e35055f31c7f (1 commits) (flutter#5829)
768daa4 Roll src/third_party/skia 5e6cd2affe41..206dbe8a21b6 (5 commits) (flutter#5828)
b8cd25b libtxt: fix a bug that used incorrect buffer size depending on conditions (flutter#5804)
b7b13b5 Roll src/third_party/skia df795638b9bd..5e6cd2affe41 (1 commits) (flutter#5824)
5886949 Roll src/third_party/skia dfe1fe40796e..df795638b9bd (1 commits) (flutter#5822)
926f546 Roll src/third_party/skia cc22d4d2fb02..dfe1fe40796e (1 commits) (flutter#5821)
04633f3 Generate process global trace identifiers for pipeline flow traces. (flutter#5818)
fb0bc05 Roll src/third_party/skia 6f6de6524c73..cc22d4d2fb02 (1 commits) (flutter#5820)
fadfff7 Mention that running git clone isn't necessary (flutter#5816)
81ec600 Roll src/third_party/skia d3509a42638a..6f6de6524c73 (5 commits) (flutter#5819)
2a77a41 Make git diff range more robust in format.sh (flutter#5813)
e555ea5 Remove trailing white spaces (flutter#5734)
4c7618a Roll src/third_party/skia fa0720436319..d3509a42638a (7 commits) (flutter#5814)
liyuqian added a commit that referenced this pull request Jul 24, 2018
95e91e3 Update tonic to pull in Android build fixes. (#5834)
29f475c Update tonic to pull in fixes to assertions and build failures on Windows. (#5833)
5474415 Roll src/third_party/skia e35055f31c7f..b8eeb808d84f (5 commits) (#5832)
380eb84 Remove unused function CreateSkiaInterface (#5812)
33a4aef Fix build break caused by flutter-team-archive/engine#5830 (#5831)
244ebd6 Reapply "Fix Dart 2 reload when running from a snapshot instead of platform.dill." (#5830)
0bad812 Migrate to a standalone Tonic repository separated from Topaz (#5817)
f949f7d Roll src/third_party/skia 206dbe8a21b6..e35055f31c7f (1 commits) (#5829)
768daa4 Roll src/third_party/skia 5e6cd2affe41..206dbe8a21b6 (5 commits) (#5828)
b8cd25b libtxt: fix a bug that used incorrect buffer size depending on conditions (#5804)
b7b13b5 Roll src/third_party/skia df795638b9bd..5e6cd2affe41 (1 commits) (#5824)
5886949 Roll src/third_party/skia dfe1fe40796e..df795638b9bd (1 commits) (#5822)
926f546 Roll src/third_party/skia cc22d4d2fb02..dfe1fe40796e (1 commits) (#5821)
04633f3 Generate process global trace identifiers for pipeline flow traces. (#5818)
fb0bc05 Roll src/third_party/skia 6f6de6524c73..cc22d4d2fb02 (1 commits) (#5820)
fadfff7 Mention that running git clone isn't necessary (#5816)
81ec600 Roll src/third_party/skia d3509a42638a..6f6de6524c73 (5 commits) (#5819)
2a77a41 Make git diff range more robust in format.sh (#5813)
e555ea5 Remove trailing white spaces (#5734)
4c7618a Roll src/third_party/skia fa0720436319..d3509a42638a (7 commits) (#5814)
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Confusing comment for ComponentElement

2 participants