Skip to content

Revert "Characters Package" - #59677

Merged
renyou merged 1 commit into
masterfrom
revert-53381-characters
Jun 17, 2020
Merged

renyou merged 1 commit into
masterfrom
revert-53381-characters

Conversation

@renyou

@renyou renyou commented Jun 17, 2020

Copy link
Copy Markdown
Contributor

This PR breaks Google internal tests.

@fluttergithubbot fluttergithubbot added p: material_ui material_ui package in flutter/packages framework flutter/packages/flutter repository. See also f: labels. labels Jun 17, 2020
@HansMuller
HansMuller self-requested a review June 17, 2020 15:19

@justinmc justinmc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

However, will we need to revert #59267 as well? That PR is actually the one that introduced the characters package, but it didn't start being used until the one reverted by this (#53381).

@justinmc

Copy link
Copy Markdown
Contributor

Making a note that I found no problem with #59267, so I won't revert it for now.

justinmc added a commit to justinmc/flutter that referenced this pull request Jun 18, 2020
zljj0818 pushed a commit to zljj0818/flutter that referenced this pull request Jun 22, 2020
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants