Repository navigation
[flutter_tools] add missing null-safety flags - #59773
Merged
jonahwilliams merged 4 commits intoJun 18, 2020
Merged
Conversation
fluttergithubbot
added
the
tool
jonahwilliams
commented
Jun 18, 2020
| BuildIOSCommand(verboseHelp: false), | ||
| BuildAppBundleCommand(verboseHelp: false), | ||
| BuildFuchsiaCommand(verboseHelp: false), | ||
| BuildAarCommand(verboseHelp: false), |
Contributor
Author
There was a problem hiding this comment.
Not sure if BuildIosFrameworks makes sense here
Member
There was a problem hiding this comment.
Probably spiritually the same as BuildAarCommand, right?
Contributor
Author
There was a problem hiding this comment.
Ahh yes, but it would need to be updated to support using BuildInfo the same way that BuildAar does.
Member
There was a problem hiding this comment.
Oh right. I got that work confused with the assemble work.
jmagman
reviewed
Jun 18, 2020
Comment on lines
+480
to
+481
| 'Whether to override the inferred null safety mode to support out of ' | ||
| 'order migrations. By default, Flutter applications will attempt to ' |
Member
There was a problem hiding this comment.
out-of-order has hyphens as an adjective.
What does "out of order" mean exactly?
| BuildIOSCommand(verboseHelp: false), | ||
| BuildAppBundleCommand(verboseHelp: false), | ||
| BuildFuchsiaCommand(verboseHelp: false), | ||
| BuildAarCommand(verboseHelp: false), |
Member
There was a problem hiding this comment.
Probably spiritually the same as BuildAarCommand, right?
This was referenced Jun 19, 2020
zljj0818
pushed a commit
to zljj0818/flutter
that referenced
this pull request
Jun 22, 2020
Some of the null-safety commands were missing - plumb them through. Ensure that verbose mode shows their output, and clean up the messaging around sound-null-safety. Fixes flutter#59769 Adds a test that validate each of the null safety supporting build commands has everything plumbed through.
8 of 10 tasks
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
Some of the null-safety commands were missing - plumb them through. Ensure that verbose mode shows their output, and clean up the messaging around sound-null-safety. Fixes flutter#59769 Adds a test that validate each of the null safety supporting build commands has everything plumbed through.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some of the null-safety commands were missing - plumb them through. Ensure that verbose mode shows their output, and clean up the messaging around sound-null-safety.
Fixes #59769
Adds a test that validate each of the null safety supporting build commands has everything plumbed through.