Skip to content

Parse build ios framework build mode from params - #59874

Merged
fluttergithubbot merged 1 commit into
flutter:masterfrom
jmagman:build-mode-ios-fw
Jun 23, 2020
Merged

Parse build ios framework build mode from params#59874
fluttergithubbot merged 1 commit into
flutter:masterfrom
jmagman:build-mode-ios-fw

Conversation

@jmagman

@jmagman jmagman commented Jun 19, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

Description

Use getBuildInfo to parse all the extra options.

Related Issues

getBuildInfo will allow us to add null-safety options easier (PR forthcoming) #59773

Tests

BuildIOSFrameworkCommand remains pretty unit-untestable at the moment. Will work on that soon.

The build_ios_framework_module_test integration validates every expected output file for this command, but that doesn't really help validating these flags...

I tested it manually and it's passing the flag to dart.

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change. If not, delete the remainder of this section.

@jmagman jmagman added platform-ios iOS applications specifically a: existing-apps Integration with existing apps via the add-to-app flow labels Jun 19, 2020
@jmagman
jmagman requested a review from jonahwilliams June 19, 2020 18:26
@jmagman jmagman self-assigned this Jun 19, 2020
@fluttergithubbot

fluttergithubbot commented Jun 19, 2020

Copy link
Copy Markdown
Contributor

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@fluttergithubbot fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jun 19, 2020
This was referenced Jun 19, 2020
Closed
Merged
jonahwilliams
jonahwilliams approved these changes Jun 22, 2020
View reviewed changes

@jonahwilliams jonahwilliams left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot
fluttergithubbot merged commit 2c538be into flutter:master Jun 23, 2020
@jmagman
jmagman deleted the build-mode-ios-fw branch June 23, 2020 00:33
@jmagman jmagman mentioned this pull request Jun 23, 2020
Merged
8 of 10 tasks
@jmagman jmagman mentioned this pull request Sep 1, 2020
Closed
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@jmagman @mingwandroid
Parse build ios framework build mode from params (flutter#59874)
d4675bf
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@jonahwilliams jonahwilliams jonahwilliams approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

a: existing-apps Integration with existing apps via the add-to-app flow platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jmagman @fluttergithubbot @jonahwilliams @googlebot