Skip to content

Revert "Export Material curves in the Material lib" - #62431

Merged
jonahwilliams merged 1 commit into
masterfrom
revert-62421-breaking_docs
Jul 28, 2020
Merged

Revert "Export Material curves in the Material lib"#62431
jonahwilliams merged 1 commit into
masterfrom
revert-62421-breaking_docs

Conversation

@jonahwilliams

@jonahwilliams jonahwilliams commented Jul 28, 2020

Copy link
Copy Markdown
Contributor

Reverts #62421

@tvolkert this is breaking multiple v2 gallery builds:

on https://flutter.dev/go/android-project-migration to migrate your project.
2020-07-28T11:47:58.649051: stdout: [        ] Generating /home/flutter/.cocoon/flutter/dev/devicelab/temp/gallery/android/app/src/main/java/io/flutter/plugins/GeneratedPluginRegistrant.java
2020-07-28T11:47:58.668811: stdout: [  +19 ms] Compiling lib/main.dart for the Web...
2020-07-28T11:47:58.678970: stdout: [  +10 ms] Initializing file store
2020-07-28T11:47:58.693715: stdout: [  +14 ms] Skipping target: gen_localizations
2020-07-28T11:47:58.705248: stdout: [  +11 ms] web_entrypoint: Starting due to {InvalidatedReason.inputChanged}
2020-07-28T11:47:58.711623: stdout: [   +6 ms] web_entrypoint: Complete
2020-07-28T11:47:58.713512: stdout: [   +1 ms] dart2js: Starting due to {}
2020-07-28T11:48:13.504744: stdout: [+14791 ms] Persisting file store
2020-07-28T11:48:13.506639: stdout: [   +1 ms] Done persisting file store
2020-07-28T11:48:13.509817: stderr: [   +1 ms] Target dart2js failed: Exception: ../../../../../../.pub-cache/hosted/pub.dartlang.org/animations-1.1.1/lib/src/fade_scale_transition.dart:148:29:
stderr:            Error: 'decelerateEasing' is imported from both 'package:flutter/src/material/curves.dart' and 'package:animations/src/utils/curves.dart'.
stderr:              ).chain(CurveTween(curve: decelerateEasing));
stderr:                                        ^^^^^^^^^^^^^^^^
stderr:            ../../../../../../.pub-cache/hosted/pub.dartlang.org/animations-1.1.1/lib/src/shared_axis_transition.dart:315:12:
stderr:            Error: 'decelerateEasing' is imported from both 'package:flutter/src/material/curves.dart' and 'package:animations/src/utils/curves.dart'.
stderr:                curve: decelerateEasing,
2020-07-28T11:48:13.509986: stderr:                       ^^^^^^^^^^^^^^^^
stderr:            ../../../../../../.pub-cache/hosted/pub.dartlang.org/animations-1.1.1/lib/src/shared_axis_transition.dart:321:29:
stderr:            Error: 'standardEasing' is imported from both 'package:flutter/src/material/curves.dart' and 'package:animations/src/utils/curves.dart'.
stderr:              ).chain(CurveTween(curve: standardEasing));
stderr:                                        ^^^^^^^^^^^^^^
stderr:            ../../../../../../.pub-cache/hosted/pub.dartlang.org/animations-1.1.1/lib/src/shared_axis_transition.dart:326:29:
stderr:            Error: 'standardEasing' is imported from both 'package:flutter/src/material/curves.dart' and 'package:animations/src/utils/curves.dart'.
stderr:              ).chain(CurveTween(curve: standardEasing));
stderr:                                        ^^^^^^^^^^^^^^
stderr:            ../../../../../../.pub-cache/hosted/pub.dartlang.org/animations-1.1.1/lib/src/shared_axis_transition.dart:335:35:
stderr:            Error: 'standardEasing' is imported from both 'package:flutter/src/material/curves.dart' and 'package:animations/src/utils/curves.dart'.
stderr:                    ).chain(CurveTween(curve: standardEasing));
stderr:                                              ^^^^^^^^^^^^^^
stderr:            ../../../../../../.pub-cache/hosted/pub.dartlang.org/animations-1.1.1/lib/src/shared_axis_transition.dart:355:35:
stderr:            Error: 'standardEasing' is imported from both 'package:flutter/src/material/curves.dart' and 'package:animations/src/utils/curves.dart'.
stderr:                    ).chain(CurveTween(curve: standardEasing));
stderr:                                              ^^^^^^^^^^^^^^
stderr:            ../../../../../../.pub-cache/hosted/pub.dartlang.org/animations-1.1.1/lib/src/shared_axis_transition.dart:402:12:
stderr:            Error: 'accelerateEasing' is imported from both 'package:flutter/src/material/curves.dart' and 'package:animations/src/utils/curves.dart'.
stderr:                curve: accelerateEasing,
stderr:                       ^^^^^^^^^^^^^^^^
stderr:            ../../../../../../.pub-cache/hosted/pub.dartlang.org/animations-1.1.1/lib/src/shared_axis_transition.dart:408:29:
stderr:            Error: 'standardEasing' is imported from both 'package:flutter/src/material/curves.dart' and 'package:animations/src/utils/curves.dart'.
stderr:              ).chain(CurveTween(curve: standardEasing));
stderr:                                        ^^^^^^^^^^^^^^
stderr:            ../../../../../../.pub-cache/hosted/pub.dartlang.org/animations-1.1.1/lib/src/shared_axis_transition.dart:413:29:
stderr:            Error: 'standardEasing' is imported from both 'package:flutter/src/material/curves.dart' and 'package:animations/src/utils/curves.dart'.
stderr:              ).chain(CurveTween(curve: standardEasing));
stderr:                                        ^^^^^^^^^^^^^^
stderr:            ../../../../../../.pub-cache/hosted/pub.dartlang.org/animations-1.1.1/lib/src/shared_axis_transition.dart:422:35:
stderr:            Error: 'standardEasing' is imported from both 'package:flutter/src/material/curves.dart' and 'package:animations/src/utils/curves.dart'.
stderr:                    ).chain(CurveTween(curve: standardEasing));
stderr:                                              ^^^^^^^^^^^^^^
stderr:            ../../../../../../.pub-cache/hosted/pub.dartlang.org/animations-1.1.1/lib/src/shared_axis_transition.dart:445:35:
stderr:            Error: 'standardEasing' is imported from both 'package:flutter/src/material/curves.dart' and 'package:animations/src/utils/curves.dart'.
stderr:                    ).chain(CurveTween(curve: standardEasing));
stderr:                                              ^^^^^^^^^^^^^^
stderr:            Error: Compilation failed.
stderr: 
2020-07-28T11:48:13.516562: stdout: [   +7 ms] Compiling lib/main.dart for the Web... (completed in 14.8s)
2020-07-28T11:48:13.517721: stdout: [   +1 ms] "flutter web" took 15,139ms.
2020-07-28T11:48:13.521106: stderr: [   +3 ms] Exception: Failed to compile application for the Web.
2020-07-28T11:48:13.522743: stderr: [   +1 ms] 
stderr:            #0      throwToolExit (package:flutter_tools/src/base/common.dart:14:3)
stderr:            #1      buildWeb (package:flutter_tools/src/web/compile.dart:79:5)
stderr:            #2      _rootRunUnary (dart:async/zone.dart:1198:47)
stderr:            #3      _CustomZone.runUnary (dart:async/zone.dart:1100:19)
stderr:            #4      _FutureListener.handleValue (dart:async/future_impl.dart:143:18)
stderr:            #5      Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:696:45)
stderr:            #6      Future._propagateToListeners (dart:async/future_impl.dart:725:32)
2020-07-28T11:48:13.523442: stderr:            #7      Future._completeWithValue (dart:async/future_impl.dart:529:5)
stderr:            #8      _AsyncAwaitCompleter.complete (dart:async-patch/async_patch.dart:40:15)
stderr:            #9      _completeOnAsyncReturn (dart:async-patch/async_patch.dart:311:13)
stderr:            #10     FlutterBuildSystem.build (package:flutter_tools/src/build_system/build_system.dart)
stderr:            #11     _rootRunUnary (dart:async/zone.dart:1198:47)
stderr:            #12     _CustomZone.runUnary (dart:async/zone.dart:1100:19)
stderr:            #13     _FutureListener.handleValue (dart:async/future_impl.dart:143:18)
stderr:            #14     Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:696:45)
stderr:            #15     Future._propagateToListeners (dart:async/future_impl.dart:725:32)
stderr:            #16     Future._completeWithValue (dart:async/future_impl.dart:529:5)
stderr:            #17     _AsyncAwaitCompleter.complete (dart:async-patch/async_patch.dart:40:15)
stderr:            #18     _completeOnAsyncReturn (dart:async-patch/async_patch.dart:311:13)
stderr:            #19     _BuildInstance.invokeTarget (package:flutter_tools/src/build_system/build_system.dart)
stderr:            #20     _rootRunUnary (dart:async/zone.dart:1198:47)
stderr:            #21     _CustomZone.runUnary (dart:async/zone.dart:1100:19)
stderr:            #22     _FutureListener.handleValue (dart:async/future_impl.dart:143:18)
stderr:            #23     Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:696:45)
stderr:            #24     Future._propagateToListeners (dart:async/future_impl.dart:725:32)
stderr:            #25     Future._completeWithValue (dart:async/future_impl.dart:529:5)
stderr:            #26     Future.wait.<anonymous closure> (dart:async/future.dart:410:22)
stderr:            #27     _rootRunUnary (dart:async/zone.dart:1198:47)
stderr:            #28     _CustomZone.runUnary (dart:async/zone.dart:1100:19)
stderr:            #29     _FutureListener.handleValue (dart:async/future_impl.dart:143:18)
stderr:            #30     Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:696:45)
stderr:            #31     Future._propagateToListeners (dart:async/future_impl.dart:725:32)
stderr:            #32     Future._completeWithValue (dart:async/future_impl.dart:529:5)
stderr:            #33     _AsyncAwaitCompleter.complete (dart:async-patch/async_patch.dart:40:15)
stderr:            #34     _completeOnAsyncReturn (dart:async-patch/async_patch.dart:311:13)
stderr:            #35     _BuildInstance.invokeTarget (package:flutter_tools/src/build_system/build_system.dart)
stderr:            #36     _rootRunUnary (dart:async/zone.dart:1198:47)
stderr:            #37     _CustomZone.runUnary (dart:async/zone.dart:1100:19)
stderr:            #38     _FutureListener.handleValue (dart:async/future_impl.dart:143:18)
stderr:            #39     Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:696:45)
stderr:            #40     Future._propagateToListeners (dart:async/future_impl.dart:725:32)
stderr:            #41     Future._completeWithValue (dart:async/future_impl.dart:529:5)
stderr:            #42     Future.wait.<anonymous closure> (dart:async/future.dart:410:22)
stderr:            #43     _rootRunUnary (dart:async/zone.dart:1198:47)
stderr:            #44     _CustomZone.runUnary (dart:async/zone.dart:1100:19)
stderr:            #45     _FutureListener.handleValue (dart:async/future_impl.dart:143:18)
stderr:            #46     Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:696:45)
stderr:            #47     Future._propagateToListeners (dart:async/future_impl.dart:725:32)
stderr:            #48     Future._completeWithValue (dart:async/future_impl.dart:529:5)
stderr:            #49     _AsyncAwaitCompleter.complete (dart:async-patch/async_patch.dart:40:15)
stderr:            #50     _completeOnAsyncReturn (dart:async-patch/async_patch.dart:311:13)
stderr:            #51     _BuildInstance._invokeInternal (package:flutter_tools/src/build_system/build_system.dart)
stderr:            #52     _asyncErrorWrapperHelper.errorCallback (dart:async-patch/async_patch.dart:91:64)
stderr:            #53     _rootRunBinary (dart:async/zone.dart:1214:47)
stderr:            #54     _CustomZone.runBinary (dart:async/zone.dart:1107:19)
stderr:            #55     _FutureListener.handleError (dart:async/future_impl.dart:157:20)
stderr:            #56     Future._propagateToListeners.handleError (dart:async/future_impl.dart:708:47)
stderr:            #57     Future._propagateToListeners (dart:async/future_impl.dart:729:24)
stderr:            #58     Future._completeError (dart:async/future_impl.dart:537:5)
stderr:            #59     _AsyncAwaitCompleter.completeError (dart:async-patch/async_patch.dart:47:15)
stderr:            #60     Dart2JSTarget.build (package:flutter_tools/src/build_system/targets/web.dart)
stderr:            #61     _rootRunUnary (dart:async/zone.dart:1198:47)
stderr:            #62     _CustomZone.runUnary (dart:async/zone.dart:1100:19)
stderr:            #63     _FutureListener.handleValue (dart:async/future_impl.dart:143:18)
stderr:            #64     Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:696:45)
stderr:            #65     Future._propagateToListeners (dart:async/future_impl.dart:725:32)
stderr:            #66     Future._completeWithValue (dart:async/future_impl.dart:529:5)
stderr:            #67     Future.wait.<anonymous closure> (dart:async/future.dart:410:22)
stderr:            #68     _rootRunUnary (dart:async/zone.dart:1198:47)
stderr:            #69     _CustomZone.runUnary (dart:async/zone.dart:1100:19)
stderr:            #70     _FutureListener.handleValue (dart:async/future_impl.dart:143:18)
stderr:            #71     Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:696:45)
stderr:            #72     Future._propagateToListeners (dart:async/future_impl.dart:725:32)
stderr:            #73     Future._completeWithValue (dart:async/future_impl.dart:529:5)
stderr:            #74     Future._asyncCompleteWithValue.<anonymous closure> (dart:async/future_impl.dart:567:7)
stderr:            #75     _rootRun (dart:async/zone.dart:1190:13)
stderr:            #76     _CustomZone.run (dart:async/zone.dart:1093:19)
stderr:            #77     _CustomZone.runGuarded (dart:async/zone.dart:997:7)
stderr:            #78     _CustomZone.bindCallbackGuarded.<anonymous closure> (dart:async/zone.dart:1037:23)
stderr:            #79     _microtaskLoop (dart:async/schedule_microtask.dart:41:21)
stderr:            #80     _startMicrotaskLoop (dart:async/schedule_microtask.dart:50:5)
stderr:            #81     _runPendingImmediateCallback (dart:isolate-patch/isolate_patch.dart:118:13)
stderr:            #82     _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:169:5)
stderr: 
stderr:

@fluttergithubbot fluttergithubbot added the p: material_ui material_ui package in flutter/packages label Jul 28, 2020
@fluttergithubbot

fluttergithubbot commented Jul 28, 2020

Copy link
Copy Markdown
Contributor

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@fluttergithubbot fluttergithubbot added the framework flutter/packages/flutter repository. See also f: labels. label Jul 28, 2020
@goderbauer

goderbauer commented Jul 28, 2020

Copy link
Copy Markdown
Member

LGtM

@jonahwilliams
jonahwilliams merged commit 1b37da4 into master Jul 28, 2020
@jonahwilliams
jonahwilliams deleted the revert-62421-breaking_docs branch July 28, 2020 18:54
goderbauer added a commit that referenced this pull request Jul 28, 2020
@goderbauer
Revert "Revert "Export Material curves in the Material lib (#62421)" (#…
08f841d 
…62431)"

This reverts commit 1b37da4.
@goderbauer goderbauer mentioned this pull request Jul 28, 2020
Merged
fluttergithubbot pushed a commit that referenced this pull request Jul 29, 2020
@goderbauer
Revert "Revert "Export Material curves in the Material lib (#62421)" (#…
ddb6d9d 
…62431)" (#62435)
Pragya007 pushed a commit to Pragya007/flutter that referenced this pull request Aug 11, 2020
Jonah Williams @Pragya007
Revert "Export Material curves in the Material lib (flutter#62421)" (f…
ce85943 
…lutter#62431)

This reverts commit 80237ef.
Pragya007 pushed a commit to Pragya007/flutter that referenced this pull request Aug 11, 2020
@goderbauer @Pragya007
Revert "Revert "Export Material curves in the Material lib (flutter#6…
75bc8c2 
…2421)" (flutter#62431)" (flutter#62435)
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
Jonah Williams @mingwandroid
Revert "Export Material curves in the Material lib (flutter#62421)" (f…
d47ae6b 
…lutter#62431)

This reverts commit 80237ef.
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@goderbauer @mingwandroid
Revert "Revert "Export Material curves in the Material lib (flutter#6…
7aed9dc 
…2421)" (flutter#62431)" (flutter#62435)
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jonahwilliams @fluttergithubbot @goderbauer @googlebot