Skip to content

Reland "Export Material curves in the Material lib" - #62435

Merged
fluttergithubbot merged 1 commit into
masterfrom
revert-62431-revert-62421-breaking_docs
Jul 29, 2020
Merged

fluttergithubbot merged 1 commit into
masterfrom
revert-62431-revert-62421-breaking_docs

Conversation

@goderbauer

Copy link
Copy Markdown
Member

Reverts #62431

A new version 1.1.2 of the animations package has been published and this should be save to land now.

@fluttergithubbot fluttergithubbot added p: material_ui material_ui package in flutter/packages framework flutter/packages/flutter repository. See also f: labels. labels Jul 28, 2020
@fluttergithubbot

Copy link
Copy Markdown
Contributor

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@jonahwilliams

Copy link
Copy Markdown
Contributor

This is not safe to land without rolling in a new version of the new gallery, right?

@goderbauer

Copy link
Copy Markdown
Member Author

Do you know where we pin the gallery version?

@jonahwilliams

Copy link
Copy Markdown
Contributor

@jonahwilliams

Copy link
Copy Markdown
Contributor

that is pulling in a gallery hash which has a lockfile checked in, so it might require an update to that

@goderbauer

Copy link
Copy Markdown
Member Author

[...] which has a lockfile checked in, so it might require an update to that

https://github.com/flutter/gallery/pull/231

@goderbauer goderbauer mentioned this pull request Jul 28, 2020
9 of 13 tasks
@goderbauer

Copy link
Copy Markdown
Member Author

New gallery version bump: #62439

@goderbauer

Copy link
Copy Markdown
Member Author

Waiting on #62439 to successfully pass device lab before submitting this.

@jonahwilliams jonahwilliams left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot
fluttergithubbot merged commit ddb6d9d into master Jul 29, 2020
@fluttergithubbot
fluttergithubbot deleted the revert-62431-revert-62421-breaking_docs branch July 29, 2020 02:56
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants