Skip to content

Revert "move compile/target sdk versions to 29" - #62884

Merged
jonahwilliams merged 1 commit into
masterfrom
revert-62799-29
Aug 4, 2020
Merged

jonahwilliams merged 1 commit into
masterfrom
revert-62799-29

Conversation

@jonahwilliams

Copy link
Copy Markdown
Contributor

Reverts #62799

Multiple devicelab machines are failing to download android-29 sources:

2020-08-04T10:52:24.777007: stdout: [+1388 ms] Checking the license for package Android SDK Platform 29 in /usr/local/share/android-sdk/licenses
2020-08-04T10:52:24.777794: stdout: [   +1 ms] License for package Android SDK Platform 29 accepted.
stdout: [        ] Preparing "Install Android SDK Platform 29 (revision: 4)".
2020-08-04T10:52:24.778500: stdout: [        ] Warning: Failed to read or create install properties file.
2020-08-04T10:52:24.780064: stderr: [   +1 ms] FAILURE: Build failed with an exception.
2020-08-04T10:52:24.780452: stderr: [        ] * What went wrong:
2020-08-04T10:52:24.780821: stderr: [        ] Could not determine the dependencies of task ':app:compileDebugJavaWithJavac'.
2020-08-04T10:52:24.781139: stderr: [        ] > Failed to install the following SDK components:
2020-08-04T10:52:24.781452: stderr: [        ]       platforms;android-29 Android SDK Platform 29
2020-08-04T10:52:24.781884: stderr: [        ]   Install the missing components using the SDK manager in Android Studio.
2020-08-04T10:52:24.782407: stderr: [        ] * Try:
2020-08-04T10:52:24.783440: stderr: [        ] Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.
stderr: [        ] * Get more help at https://help.gradle.org
2020-08-04T10:52:24.784339: stderr: [        ] BUILD FAILED in 1s
2020-08-04T10:52:25.227565: stdout: [ +443 ms] Running Gradle task 'assembleDebug'... (completed in 1.9s)
2020-08-04T10:52:25.235111: stdout: [   +7 ms] "flutter drive" took 4,801ms.
2020-08-04T10:52:25.241076: stderr: [   +6 ms] Gradle task assembleDebug failed with exit code 1

@flutter-dashboard flutter-dashboard Bot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) d: examples Sample code and demos c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Aug 4, 2020
@jonahwilliams

Copy link
Copy Markdown
Contributor Author

@xster

@jonahwilliams
jonahwilliams requested a review from xster August 4, 2020 18:15
@xster

xster commented Aug 4, 2020

Copy link
Copy Markdown
Member

LGTM

@jonahwilliams

Copy link
Copy Markdown
Contributor Author

Landing on red to fix build

@jonahwilliams
jonahwilliams merged commit e8ad863 into master Aug 4, 2020
@jonahwilliams
jonahwilliams deleted the revert-62799-29 branch August 4, 2020 18:20
@blasten

blasten commented Aug 4, 2020

Copy link
Copy Markdown

The SDK needs to be installed in the host via sdkmanager "platform-tools" "platforms;android-29". cc @godofredoc for the infra dependency.

We should probably update flutter doctor, so it accounts for this new requirement prior to running flutter create/flutter build.

@godofredoc

Copy link
Copy Markdown
Contributor

Android in devicelab machines is manually provisioned.

Pragya007 pushed a commit to Pragya007/flutter that referenced this pull request Aug 11, 2020
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) c: contributor-productivity Team-specific productivity, code health, technical debt. d: examples Sample code and demos tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants