Skip to content

move compile/target sdk versions to 29 - #62799

Merged
fluttergithubbot merged 1 commit into
flutter:masterfrom
xster:29
Aug 4, 2020
Merged

fluttergithubbot merged 1 commit into
flutter:masterfrom
xster:29

Conversation

@xster

@xster xster commented Aug 3, 2020 •

Copy link
Copy Markdown
Member

Fixes #54382

(we already moved our engine builds to 29 last year)

@xster
xster requested a review from jmagman August 3, 2020 18:23
@flutter-dashboard flutter-dashboard Bot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) d: examples Sample code and demos c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Aug 3, 2020

@jmagman jmagman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xster This doesn't cause any new warnings in new projects, right?

@xster

xster commented Aug 3, 2020

Copy link
Copy Markdown
Member Author

oh wow, actually just checked. Android fancy now #54382 (comment)

@jmagman jmagman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming this doesn't cause any new warnings in new projects.
Similar to #26444 and #26790 and #26798

@xster

xster commented Aug 4, 2020

Copy link
Copy Markdown
Member Author

Ya, that's what I meant to say. It does not. It's a smooth transition as far as I can tell.

@fluttergithubbot
fluttergithubbot merged commit 5b3dc52 into flutter:master Aug 4, 2020
jonahwilliams pushed a commit that referenced this pull request Aug 4, 2020
jonahwilliams pushed a commit that referenced this pull request Aug 4, 2020
Pragya007 pushed a commit to Pragya007/flutter that referenced this pull request Aug 11, 2020
Pragya007 pushed a commit to Pragya007/flutter that referenced this pull request Aug 11, 2020
xster added a commit to xster/flutter that referenced this pull request Aug 11, 2020
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) c: contributor-productivity Team-specific productivity, code health, technical debt. d: examples Sample code and demos tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Android SDK from 28 to 29 in new plugins and project templates

4 participants