Repository navigation
[flutter_tools] split application package factory dependencies - #79461
Merged
jonahwilliams merged 3 commits intoMar 31, 2021
Merged
Conversation
flutter-dashboard
Bot
added
the
tool
Contributor
Author
|
I think the g3 failure is a merge issue - I don't see any actual usage of the interface so I'm going to land once the tree is green. |
Member
Were you rebased on https://github.com/flutter/flutter/pull/79342/files#diff-e24013dd662b438105ef0c1d965a955e4344a6481bc2e6cbe87a30357314fb69L10 ? |
Member
|
Oh I see, g3 doesn't have #79342 yet, so it thinks |
Member
Hoisted by your own petard #79454 |
Contributor
Author
|
Ehh, cost of doing business :) |
This was referenced Mar 31, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the iOS/Android dependencies from the application package factory. This will make it easier to migrate it and device.dart, which are both super common dependencies. This moves the ios/android application package classes into {ios/android}/application_package.dart
#71511