Skip to content

[material_ui] Migrate AppBar M3 template to use new gen_defaults script - #12122

Merged
QuncCccccc merged 4 commits into
flutter:m3e_migrationfrom
QuncCccccc:app_bar_m3_defaults_migration
Jul 16, 2026
Merged

[material_ui] Migrate AppBar M3 template to use new gen_defaults script#12122
QuncCccccc merged 4 commits into
flutter:m3e_migrationfrom
QuncCccccc:app_bar_m3_defaults_migration

Conversation

@QuncCccccc

@QuncCccccc QuncCccccc commented Jul 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Will land #12209 first.

Fixes flutter/flutter#188397

Initially gen_defaults script and its templates were used to handle JSON tokens. After we fix the token pipeline and make it possible to get M3E tokens, we use Dart constants and re-created the gen_defaults in material_ui. After decoupling, the old gen_defaults will be deprecated soon.

This PR is to:

  • create a template for M3 AppBar so we can use new script to generate M3 defaults.
  • move the generated code to generated/ folder so all M3 and M3E generated code will be in the same location.

Pre-Review Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools.
  • I read the [Tree Hygiene] page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran [the auto-formatter].
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I [linked to at least one issue that this PR fixes] in the description above.
  • I followed [the version and CHANGELOG instructions], using [semantic versioning] and the [repository CHANGELOG style], or I have commented below to indicate which documented exception this PR falls under[^1].
  • I updated/added any relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or I have commented below to indicate which [test exemption] this PR falls under[^1].
  • All existing and new tests are passing.

@github-actions github-actions Bot added triage-framework Should be looked at in framework triage p: material_ui labels Jul 6, 2026
@QuncCccccc QuncCccccc changed the title Migrate AppBar M3 template to use new gen_defaults script [material_ui] Migrate AppBar M3 template to use new gen_defaults script Jul 6, 2026
@QuncCccccc
QuncCccccc force-pushed the app_bar_m3_defaults_migration branch from 0d0154f to 8f8747b Compare July 14, 2026 20:36
@QuncCccccc
QuncCccccc requested a review from elliette July 14, 2026 23:22
@QuncCccccc
QuncCccccc marked this pull request as ready for review July 14, 2026 23:22
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Jul 14, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request extracts the generated Material 3 AppBar defaults into a separate file, app_bar_m3_defaults.g.dart, and introduces an AppBarTemplate class to generate this file automatically. A unit test has also been added to verify the generated defaults. Feedback suggests removing an obsolete // ignore: unused_local_variable comment in gen_defaults.dart since the verbose variable is now utilized.

Comment thread packages/material_ui/tool/gen_defaults/bin/gen_defaults.dart Outdated
elliette
elliette reviewed Jul 15, 2026
View reviewed changes

@elliette elliette left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't done a thorough review, just a few quick questions.

Comment thread packages/material_ui/tool/gen_defaults/templates/app_bar_template.dart
Comment thread packages/material_ui/lib/src/generated/app_bar_defaults_m3.g.dart
@QuncCccccc
QuncCccccc force-pushed the app_bar_m3_defaults_migration branch 4 times, most recently from f712d9a to 35ed6ca Compare July 15, 2026 22:55
@QuncCccccc
QuncCccccc marked this pull request as draft July 15, 2026 23:12
@QuncCccccc
QuncCccccc force-pushed the app_bar_m3_defaults_migration branch from 35ed6ca to 999efe9 Compare July 15, 2026 23:16
@QuncCccccc
QuncCccccc force-pushed the app_bar_m3_defaults_migration branch from 999efe9 to e7f21ae Compare July 15, 2026 23:32
@QuncCccccc
QuncCccccc marked this pull request as ready for review July 15, 2026 23:44
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Jul 15, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates the generation of Material 3 AppBar defaults to a new template-based generator. It removes the hardcoded defaults and scroll-under configurations from 'app_bar.dart' and moves them to a generated file 'app_bar_defaults_m3.g.dart'. A new 'AppBarTemplateM3' class is introduced to generate these defaults from token data, the 'gen_defaults.dart' tool is updated to invoke this template, and corresponding unit tests are added in 'gen_defaults_test.dart'. There are no review comments, and I have no feedback to provide.

elliette
elliette approved these changes Jul 15, 2026
View reviewed changes

@elliette elliette left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@QuncCccccc
QuncCccccc merged commit 0ffd66f into flutter:m3e_migration Jul 16, 2026
3 of 4 checks passed
@elliette elliette mentioned this pull request Aug 13, 2026
Closed
@elliette elliette mentioned this pull request Aug 31, 2026
Merged
11 tasks done
auto-submit Bot pushed a commit that referenced this pull request Sep 1, 2026
@elliette
[material_ui] Migrate AppBar M3 template to use new gen_defaults scri…
7a7912f 
…pt (#12707)

Work towards flutter/flutter#191088

**Ports over #12122 which landed on the `m3e_migration` feature branch.**

### Original PR description

Fixes flutter/flutter#188397

Initially gen_defaults script and its templates were used to handle JSON tokens. After we fix the token pipeline and make it possible to get M3E tokens, we use Dart constants and re-created the gen_defaults in material_ui. After decoupling, the old gen_defaults will be deprecated soon.

This PR is to:

create a template for M3 AppBar so we can use new script to generate M3 defaults.
move the generated code to generated/ folder so all M3 and M3E generated code will be in the same location.

## Pre-Review Checklist

**Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
victorsanni pushed a commit to victorsanni/packages that referenced this pull request Sep 9, 2026
@elliette @victorsanni
[material_ui] Migrate AppBar M3 template to use new gen_defaults scri…
bdd78dc 
…pt (flutter#12707)

Work towards flutter/flutter#191088

**Ports over flutter#12122 which landed on the `m3e_migration` feature branch.**

### Original PR description

Fixes flutter/flutter#188397

Initially gen_defaults script and its templates were used to handle JSON tokens. After we fix the token pipeline and make it possible to get M3E tokens, we use Dart constants and re-created the gen_defaults in material_ui. After decoupling, the old gen_defaults will be deprecated soon.

This PR is to:

create a template for M3 AppBar so we can use new script to generate M3 defaults.
move the generated code to generated/ folder so all M3 and M3E generated code will be in the same location.

## Pre-Review Checklist

**Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
victorsanni pushed a commit to victorsanni/packages that referenced this pull request Sep 9, 2026
@elliette @victorsanni
[material_ui] Migrate AppBar M3 template to use new gen_defaults scri…
9dc381c 
…pt (flutter#12707)

Work towards flutter/flutter#191088

**Ports over flutter#12122 which landed on the `m3e_migration` feature branch.**

### Original PR description

Fixes flutter/flutter#188397

Initially gen_defaults script and its templates were used to handle JSON tokens. After we fix the token pipeline and make it possible to get M3E tokens, we use Dart constants and re-created the gen_defaults in material_ui. After decoupling, the old gen_defaults will be deprecated soon.

This PR is to:

create a template for M3 AppBar so we can use new script to generate M3 defaults.
move the generated code to generated/ folder so all M3 and M3E generated code will be in the same location.

## Pre-Review Checklist

**Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@elliette elliette elliette approved these changes
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

p: material_ui triage-framework Should be looked at in framework triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@QuncCccccc @elliette