Skip to content

[material_ui] Standardize M3 and M3E token template base class names - #12209

Merged
QuncCccccc merged 2 commits into
flutter:m3e_migrationfrom
QuncCccccc:gen_defaults_token_template_renaming
Jul 15, 2026
Merged

QuncCccccc merged 2 commits into
flutter:m3e_migrationfrom
QuncCccccc:gen_defaults_token_template_renaming

Conversation

@QuncCccccc

Copy link
Copy Markdown
Contributor

As title. Related to flutter/flutter#187899

Pre-Review Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools.
  • I read the [Tree Hygiene] page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran [the auto-formatter].
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I [linked to at least one issue that this PR fixes] in the description above.
  • I followed [the version and CHANGELOG instructions], using [semantic versioning] and the [repository CHANGELOG style], or I have commented below to indicate which documented exception this PR falls under[^1].
  • I updated/added any relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or I have commented below to indicate which [test exemption] this PR falls under[^1].
  • All existing and new tests are passing.

@QuncCccccc
QuncCccccc requested a review from elliette July 15, 2026 22:38
@github-actions github-actions Bot added triage-framework Should be looked at in framework triage p: material_ui labels Jul 15, 2026
@QuncCccccc

Copy link
Copy Markdown
Contributor Author

The generated file is still follow <component_name>_defaults_m3.g.dart, maybe we update it when we migrate?

@QuncCccccc
QuncCccccc marked this pull request as ready for review July 15, 2026 22:40

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request renames several template classes and subclasses across the gen_defaults tool, tests, and documentation to standardize naming conventions (e.g., renaming M3TokenTemplate to TokenTemplateM3). Feedback recommends restoring a blank line before a test block in gen_defaults_test.dart to maintain consistent spacing and readability.

Comment thread packages/material_ui/tool/gen_defaults/test/gen_defaults_test.dart
@QuncCccccc
QuncCccccc force-pushed the gen_defaults_token_template_renaming branch from 1e433fb to 4aa70e4 Compare July 15, 2026 22:47
@elliette

Copy link
Copy Markdown
Member

The generated file is still follow <component_name>_defaults_m3.g.dart, maybe we update it when we migrate?

Yes, sounds good! I think right now they don't have the _m3 suffix, so we can add it when we move the files.

@elliette elliette left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening a separate PR for this, LGTM!

@QuncCccccc
QuncCccccc merged commit 26df25d into flutter:m3e_migration Jul 15, 2026
3 of 4 checks passed
QuncCccccc added a commit that referenced this pull request Jul 16, 2026
…pt (#12122)

~Will land #12209 first.~

Fixes flutter/flutter#188397

Initially gen_defaults script and its templates were used to handle JSON
tokens. After we fix the token pipeline and make it possible to get M3E
tokens, we use Dart constants and re-created the gen_defaults in
material_ui. After decoupling, the old gen_defaults will be deprecated
soon.

This PR is to:
* create a template for M3 `AppBar` so we can use new script to generate
M3 defaults.
* move the generated code to `generated/` folder so all M3 and M3E
generated code will be in the same location.

## Pre-Review Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [AI contribution guidelines] and understand my
responsibilities, or I am not using AI tools.
- [x] I read the [Tree Hygiene] page, which explains my
responsibilities.
- [x] I read and followed the [relevant style guides] and ran [the
auto-formatter].
- [x] I signed the [CLA].
- [x] The title of the PR starts with the name of the package surrounded
by square brackets, e.g. `[shared_preferences]`
- [x] I [linked to at least one issue that this PR fixes] in the
description above.
- [ ] I followed [the version and CHANGELOG instructions], using
[semantic versioning] and the [repository CHANGELOG style], or I have
commented below to indicate which documented exception this PR falls
under[^1].
- [x] I updated/added any relevant documentation (doc comments with
`///`).
- [x] I added new tests to check the change I am making, or I have
commented below to indicate which [test exemption] this PR falls
under[^1].
- [ ] All existing and new tests are passing.
auto-submit Bot pushed a commit that referenced this pull request Aug 31, 2026
…12675)

Work towards flutter/flutter#191088

**Ports over #12209 which landed on the `m3e_migration` feature branch.**

### Original PR description

As title. Related to flutter/flutter#187899

## Pre-Review Checklist

**Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
victorsanni pushed a commit to victorsanni/packages that referenced this pull request Sep 9, 2026
…lutter#12675)

Work towards flutter/flutter#191088

**Ports over flutter#12209 which landed on the `m3e_migration` feature branch.**

### Original PR description

As title. Related to flutter/flutter#187899

## Pre-Review Checklist

**Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
victorsanni pushed a commit to victorsanni/packages that referenced this pull request Sep 9, 2026
…lutter#12675)

Work towards flutter/flutter#191088

**Ports over flutter#12209 which landed on the `m3e_migration` feature branch.**

### Original PR description

As title. Related to flutter/flutter#187899

## Pre-Review Checklist

**Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p: material_ui triage-framework Should be looked at in framework triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants