Repository navigation
[material_ui] Standardize M3 and M3E token template base class names - #12209
QuncCccccc merged 2 commits into
Conversation
|
The generated file is still follow |
There was a problem hiding this comment.
Code Review
This pull request renames several template classes and subclasses across the gen_defaults tool, tests, and documentation to standardize naming conventions (e.g., renaming M3TokenTemplate to TokenTemplateM3). Feedback recommends restoring a blank line before a test block in gen_defaults_test.dart to maintain consistent spacing and readability.
1e433fb to
4aa70e4
Compare
Yes, sounds good! I think right now they don't have the |
elliette
left a comment
There was a problem hiding this comment.
Thank you for opening a separate PR for this, LGTM!
…pt (#12122) ~Will land #12209 first.~ Fixes flutter/flutter#188397 Initially gen_defaults script and its templates were used to handle JSON tokens. After we fix the token pipeline and make it possible to get M3E tokens, we use Dart constants and re-created the gen_defaults in material_ui. After decoupling, the old gen_defaults will be deprecated soon. This PR is to: * create a template for M3 `AppBar` so we can use new script to generate M3 defaults. * move the generated code to `generated/` folder so all M3 and M3E generated code will be in the same location. ## Pre-Review Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] page, which explains my responsibilities. - [x] I read and followed the [relevant style guides] and ran [the auto-formatter]. - [x] I signed the [CLA]. - [x] The title of the PR starts with the name of the package surrounded by square brackets, e.g. `[shared_preferences]` - [x] I [linked to at least one issue that this PR fixes] in the description above. - [ ] I followed [the version and CHANGELOG instructions], using [semantic versioning] and the [repository CHANGELOG style], or I have commented below to indicate which documented exception this PR falls under[^1]. - [x] I updated/added any relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or I have commented below to indicate which [test exemption] this PR falls under[^1]. - [ ] All existing and new tests are passing.
…12675) Work towards flutter/flutter#191088 **Ports over #12209 which landed on the `m3e_migration` feature branch.** ### Original PR description As title. Related to flutter/flutter#187899 ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
…lutter#12675) Work towards flutter/flutter#191088 **Ports over flutter#12209 which landed on the `m3e_migration` feature branch.** ### Original PR description As title. Related to flutter/flutter#187899 ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
…lutter#12675) Work towards flutter/flutter#191088 **Ports over flutter#12209 which landed on the `m3e_migration` feature branch.** ### Original PR description As title. Related to flutter/flutter#187899 ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
As title. Related to flutter/flutter#187899
Pre-Review Checklist
[shared_preferences]///).