Repository navigation
[material_ui] Add a README and placeholders for migrating gen_defaults templates - #12220
Merged
elliette merged 6 commits intoJul 16, 2026
Merged
Conversation
github-actions
Bot
added
triage-framework
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a README file to the packages/material_ui/tool/gen_defaults/temporarily_excluded/ directory, providing instructions for migrating templates and generated code. The review identified two improvements: clarifying the naming convention placeholders used in the instructions and correcting the Git command sequence for staging and committing moved files.
…ADME.md Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…ADME.md Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
QuncCccccc
approved these changes
Jul 16, 2026
QuncCccccc
left a comment
QuncCccccc
left a comment
Contributor
There was a problem hiding this comment.
LGTM with minor comments.
|
|
||
| // const ActionChipTemplateM3().generateFile(verbose: verbose); | ||
| const AppBarTemplateM3().generateFile(verbose: verbose); | ||
| // const BadgeTemplateM3().generateFile(verbose: verbose); |
Contributor
There was a problem hiding this comment.
Smart way to avoid conflict!!
elliette
changed the title
gen_defaults templatesgen_defaults templates
11 tasks done
auto-submit Bot
pushed a commit
that referenced
this pull request
Sep 2, 2026
…s templates (#12714) Work towards flutter/flutter#191088 **Ports over #12220 which landed on the `m3e_migration` feature branch.** ### Original PR description Work towards flutter/flutter#187899 * Adds a README on how to migrate the gen_defaults templates, to be used by contributors or agents. * Adds placeholders (referenced in README) for templates to prevent merge conflicts while migrating. ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
victorsanni
pushed a commit
to victorsanni/packages
that referenced
this pull request
Sep 9, 2026
…s templates (flutter#12714) Work towards flutter/flutter#191088 **Ports over flutter#12220 which landed on the `m3e_migration` feature branch.** ### Original PR description Work towards flutter/flutter#187899 * Adds a README on how to migrate the gen_defaults templates, to be used by contributors or agents. * Adds placeholders (referenced in README) for templates to prevent merge conflicts while migrating. ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
victorsanni
pushed a commit
to victorsanni/packages
that referenced
this pull request
Sep 9, 2026
…s templates (flutter#12714) Work towards flutter/flutter#191088 **Ports over flutter#12220 which landed on the `m3e_migration` feature branch.** ### Original PR description Work towards flutter/flutter#187899 * Adds a README on how to migrate the gen_defaults templates, to be used by contributors or agents. * Adds placeholders (referenced in README) for templates to prevent merge conflicts while migrating. ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work towards flutter/flutter#187899
gen_defaultstemplates, to be used by contributors or agents.Pre-Review Checklist
[shared_preferences]///).Test exemption: Markdown file only.
If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2