Repository navigation
[material_ui] Add a README and placeholders for migrating gen_defaults templates - #12714
Merged
Merged
Conversation
github-actions
Bot
added
p: material_ui
triage-design
elliette
added
override: no versioning needed
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a migration guide README.md for temporarily excluded gen_defaults templates, comments out several template imports and generation calls in gen_defaults.dart, and adds corresponding placeholder test cases in gen_defaults_test.dart. Feedback on the README.md includes removing trailing whitespace, fixing a typo, ensuring consistent placeholder usage, and adding a trailing newline at the end of the file.
github-actions
Bot
added
p: material_ui
triage-design
elliette
added
the
autosubmit
This was referenced Sep 2, 2026
pull Bot
pushed a commit
to Mu-L/flutter
that referenced
this pull request
Sep 2, 2026
…r#192191) flutter/packages@7a7912f...18fe786 2026-09-02 [email protected] [path_parsing] Fix deprecation lints (flutter/packages#12704) 2026-09-02 [email protected] [material_ui] Use super parameters in more places (flutter/packages#12460) 2026-09-02 [email protected] [material_ui] Add a README and placeholders for migrating gen_defaults templates (flutter/packages#12714) 2026-09-01 [email protected] [image_picker] Add native tests for image, metadata, photo-asset, and PHPicker save utilities (flutter/packages#12536) 2026-09-01 [email protected] [material_ui] Port routes_transition_test to material_ui (flutter/packages#12634) 2026-09-01 [email protected] Roll Flutter from c8c5e3b to 0cbd1a4 (23 revisions) (flutter/packages#12712) 2026-09-01 [email protected] [material_ui] Remove !chrome in text_field_test.dart (flutter/packages#12548) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni
pushed a commit
to victorsanni/packages
that referenced
this pull request
Sep 9, 2026
…s templates (flutter#12714) Work towards flutter/flutter#191088 **Ports over flutter#12220 which landed on the `m3e_migration` feature branch.** ### Original PR description Work towards flutter/flutter#187899 * Adds a README on how to migrate the gen_defaults templates, to be used by contributors or agents. * Adds placeholders (referenced in README) for templates to prevent merge conflicts while migrating. ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
victorsanni
pushed a commit
to victorsanni/packages
that referenced
this pull request
Sep 9, 2026
…s templates (flutter#12714) Work towards flutter/flutter#191088 **Ports over flutter#12220 which landed on the `m3e_migration` feature branch.** ### Original PR description Work towards flutter/flutter#187899 * Adds a README on how to migrate the gen_defaults templates, to be used by contributors or agents. * Adds placeholders (referenced in README) for templates to prevent merge conflicts while migrating. ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work towards flutter/flutter#191088
Ports over #12220 which landed on the
m3e_migrationfeature branch.Original PR description
Work towards flutter/flutter#187899
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2