Repository navigation
[material_ui] Migrate M3 BottomSheet template to use new gen_defaults - #12223
Merged
Merged
Conversation
github-actions
Bot
added
triage-framework
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request migrates the Material 3 bottom sheet defaults to a generated part file using a new BottomSheetTemplateM3 template in the gen_defaults tool. The feedback suggests updating the constructor indentation in the template to match standard Dart formatting and using double literals for BoxConstraints to ensure consistency.
Comment on lines
+21
to
+27
| $className(this.context) | ||
| : super( | ||
| elevation: ${number(TokenSheetBottom.dockedStandardContainerElevation)}, | ||
| modalElevation: ${number(TokenSheetBottom.dockedModalContainerElevation)}, | ||
| shape: ${shape(TokenSheetBottom.dockedContainerShape)}, | ||
| constraints: const BoxConstraints(maxWidth: 640), | ||
| ); |
Contributor
There was a problem hiding this comment.
For consistency with the constraints getter on line 48, and to explicitly use double literals for BoxConstraints parameters, use 640.0 instead of 640.
Additionally, updating the constructor's indentation to match the standard Dart style guide (which is what dart format produces) makes the template code cleaner and easier to maintain.
Suggested change
| $className(this.context) | |
| : super( | |
| elevation: ${number(TokenSheetBottom.dockedStandardContainerElevation)}, | |
| modalElevation: ${number(TokenSheetBottom.dockedModalContainerElevation)}, | |
| shape: ${shape(TokenSheetBottom.dockedContainerShape)}, | |
| constraints: const BoxConstraints(maxWidth: 640), | |
| ); | |
| $className(this.context) | |
| : super( | |
| elevation: ${number(TokenSheetBottom.dockedStandardContainerElevation)}, | |
| modalElevation: ${number(TokenSheetBottom.dockedModalContainerElevation)}, | |
| shape: ${shape(TokenSheetBottom.dockedContainerShape)}, | |
| constraints: const BoxConstraints(maxWidth: 640.0), | |
| ); |
References
- Code should follow the relevant style guides and use the correct auto-formatter (dart format for Dart). Aligning the template's formatting with the formatter's output ensures consistency and readability. (link)
elliette
force-pushed
the
bottom-sheet-migration
branch
from
August 6, 2026 17:06
75c2645 to
1bde09d
Compare
11 tasks done
auto-submit Bot
pushed a commit
that referenced
this pull request
Sep 3, 2026
…#12731) Work towards flutter/flutter#191088 **Ports over #12223 which landed on the `m3e_migration` feature branch.** ### Original PR description Work towards flutter/flutter#187899 Fixes flutter/flutter#188404 ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
victorsanni
pushed a commit
to victorsanni/packages
that referenced
this pull request
Sep 9, 2026
…flutter#12731) Work towards flutter/flutter#191088 **Ports over flutter#12223 which landed on the `m3e_migration` feature branch.** ### Original PR description Work towards flutter/flutter#187899 Fixes flutter/flutter#188404 ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
victorsanni
pushed a commit
to victorsanni/packages
that referenced
this pull request
Sep 9, 2026
…flutter#12731) Work towards flutter/flutter#191088 **Ports over flutter#12223 which landed on the `m3e_migration` feature branch.** ### Original PR description Work towards flutter/flutter#187899 Fixes flutter/flutter#188404 ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work towards flutter/flutter#187899
Fixes flutter/flutter#188404
Pre-Review Checklist
[shared_preferences]///).Test exemption: Template migration PR.
If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.[test exemption]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#tests*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*
Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2