Skip to content

[material_ui] Migrate M3 BottomSheet template to use new gen_defaults - #12731

Merged
auto-submit[bot] merged 2 commits into
flutter:mainfrom
elliette:port-pr-12223
Sep 3, 2026
Merged

auto-submit[bot] merged 2 commits into
flutter:mainfrom
elliette:port-pr-12223

Conversation

@elliette

@elliette elliette commented Sep 2, 2026

Copy link
Copy Markdown
Member

Work towards flutter/flutter#191088

Ports over #12223 which landed on the m3e_migration feature branch.

Original PR description

Work towards flutter/flutter#187899
Fixes flutter/flutter#188404

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Sep 2, 2026
@elliette elliette added override: no versioning needed Override the check requiring version bumps for most changes and removed CICD Run CI/CD labels Sep 2, 2026
@elliette elliette added the override: no changelog needed Override the check requiring CHANGELOG updates for most changes label Sep 2, 2026
@github-actions github-actions Bot added the triage-design Should be looked at in design triage label Sep 2, 2026
@elliette
elliette requested a review from QuncCccccc September 2, 2026 21:41
@elliette elliette added the CICD Run CI/CD label Sep 2, 2026

@QuncCccccc QuncCccccc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elliette elliette added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 3, 2026
@auto-submit
auto-submit Bot merged commit 103a3bd into flutter:main Sep 3, 2026
13 checks passed
pull Bot pushed a commit to fucheng-guo-sun/flutter that referenced this pull request Sep 4, 2026
…r#192292)

flutter/packages@f9b3954...9af9c60

2026-09-03 [email protected] [material_ui]
Copies a11y_assessments (flutter/packages#12686)
2026-09-03 [email protected] [material_ui]
Migrate M3 BottomSheet template to use new gen_defaults
(flutter/packages#12731)
2026-09-03 [email protected] [material_ui]
Migrate M3 ActionChip template to use new gen_defaults
(flutter/packages#12732)
2026-09-03 [email protected] [camera] Add setImageQuality for
JPEG compression control (flutter/packages#11155)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni pushed a commit to victorsanni/packages that referenced this pull request Sep 9, 2026
…flutter#12731)

Work towards flutter/flutter#191088

**Ports over flutter#12223 which landed on the `m3e_migration` feature branch.**

### Original PR description

Work towards flutter/flutter#187899
Fixes flutter/flutter#188404

## Pre-Review Checklist

**Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
victorsanni pushed a commit to victorsanni/packages that referenced this pull request Sep 9, 2026
…flutter#12731)

Work towards flutter/flutter#191088

**Ports over flutter#12223 which landed on the `m3e_migration` feature branch.**

### Original PR description

Work towards flutter/flutter#187899
Fixes flutter/flutter#188404

## Pre-Review Checklist

**Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD override: no changelog needed Override the check requiring CHANGELOG updates for most changes override: no versioning needed Override the check requiring version bumps for most changes p: material_ui triage-design Should be looked at in design triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bottom_sheet_template.dart

2 participants