Repository navigation
[quick_actions_ios]unskip XCUITests - #12436
Merged
auto-submit[bot] merged 3 commits intoAug 24, 2026
Merged
auto-submit[bot] merged 3 commits into
auto-submit[bot] merged 3 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request re-enables the testQuickActionWithFreshStart and testQuickActionWhenAppIsInBackground UI tests in RunnerUITests.swift by removing the temporary XCTSkip statements and their associated comments. There are no review comments, and I have no feedback to provide.
hellohuanlin
force-pushed
the
quick_actions_unskip_ios_xcuitests
branch
from
August 18, 2026 21:28
7d66fda to
f935f31
Compare
Contributor
|
@hellohuanlin The tests are still failing, is this ready for review? |
hellohuanlin
marked this pull request as draft
August 20, 2026 19:38
Contributor
Author
|
@vashworth sorry still on it. converted to draft |
Contributor
Author
|
The test passed now, but it takes 120+ seconds. I filed a separate issue here: flutter/flutter#191467 |
hellohuanlin
marked this pull request as ready for review
August 21, 2026 04:30
Contributor
There was a problem hiding this comment.
Code Review
This pull request re-enables the testQuickActionWithFreshStart and testQuickActionWhenAppIsInBackground UI tests in RunnerUITests.swift. It updates the springboard icon name to "Quick Actions Example" and modifies the element queries to use descendants(matching: .any) instead of otherElements to accommodate changes in Flutter's semantics type representation. There are no review comments, and I have no feedback to provide.
okorohelijah
approved these changes
Aug 24, 2026
vashworth
approved these changes
Aug 24, 2026
hellohuanlin
added
the
autosubmit
This was referenced Aug 25, 2026
zijiehe-google-com
pushed a commit
to zijiehe-google-com/flutter
that referenced
this pull request
Aug 25, 2026
…er#191734) flutter/packages@df2ba94...740f093 2026-08-25 [email protected] [cupertino_ui] Remove unused parameters from constructors of generic classes. (flutter/packages#12457) 2026-08-25 [email protected] [material_ui] Remove unused parameters from constructors of generic classes. (flutter/packages#12458) 2026-08-25 [email protected] Ignore shared code for iOS platform implementation of Google Maps plugin (flutter/packages#12529) 2026-08-25 [email protected] [cross_file] fixed `readAsString` decoding in-memory bytes as UTF-16 (flutter/packages#12479) 2026-08-25 [email protected] [cupertino_ui] Remove two items assert to allow CupertinoTabBar to have one tab (flutter/packages#12546) 2026-08-25 [email protected] [cupertino_ui] Fix covered sheet revealing root route through top gap (flutter/packages#12530) 2026-08-25 [email protected] Sync release-go_router-18.0.0 to main (flutter/packages#12575) 2026-08-25 [email protected] Sync release-material_ui-1.1.0 to main (flutter/packages#12577) 2026-08-25 [email protected] Sync release-cupertino_ui-1.0.1 to main (flutter/packages#12576) 2026-08-24 [email protected] [quick_actions_ios]unskip XCUITests (flutter/packages#12436) 2026-08-24 [email protected] Fix RangeSlider thumb overlay remains visible after touch interaction ends (flutter/packages#12560) 2026-08-24 [email protected] [google_sign_in] Increase iOS coverage tests (flutter/packages#12484) 2026-08-24 [email protected] [camera_android_camerax] Migrate from dart_skills_lint to skills_lint (flutter/packages#12543) 2026-08-24 [email protected] [go_router] Clarify onEnter/redirect ordering, add regression test (flutter/packages#12337) 2026-08-24 [email protected] [material_ui] Port flutter/flutter flutter#185149 "Slider label clips the screen" (flutter/packages#12572) 2026-08-24 [email protected] Roll Flutter from 65c9a8d to 9a82789 (17 revisions) (flutter/packages#12578) 2026-08-24 [email protected] [tool] Fix dart_test.yaml parsing (flutter/packages#12574) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
jagadeesh8682
pushed a commit
to jagadeesh8682/packages
that referenced
this pull request
Sep 2, 2026
It looks like flutter/flutter#169928 has been addressed, so the test should already been passing. See also: flutter/flutter#170180 (comment) *List which issues are fixed by this PR. You must list at least one issue.* Fixes flutter/flutter#190966 ## Pre-Review Checklist **Comment: only test change** **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like flutter/flutter#169928 has been addressed, so the test should already been passing.
See also: flutter/flutter#170180 (comment)
List which issues are fixed by this PR. You must list at least one issue.
Fixes flutter/flutter#190966
Pre-Review Checklist
[shared_preferences]Comment: only test change
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2