Repository navigation
Fix RangeSlider thumb overlay remains visible after touch interaction ends - #12560
Merged
auto-submit[bot] merged 8 commits intoAug 24, 2026
Merged
Conversation
github-actions
Bot
added
p: material_ui
triage-design
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the RangeSlider component to manage focus highlights for individual thumbs using FocusableActionDetector. It introduces state variables and handlers for start and end thumb focus highlights, updates the widget states to include WidgetState.focused when focused, and ensures the active drag overlay remains visible during an in-progress drag even if the pointer moves outside the thumb bounds. Additionally, corresponding unit tests and a changelog entry have been added. There are no review comments, so no feedback is provided.
Contributor
Author
|
@Piinks could you take a look at this when you get a chance, or route it to the right reviewer? This is a port of flutter/flutter#189610 (already reviewed/approved by @QuncCccccc and @victorsanni there) — flagging for triage given the decoupling coordination in flutter/flutter#188444. |
Contributor
|
@KarthikManikuttan please avoid pinging people directly and allow the triage process to pick this up. |
QuncCccccc
approved these changes
Aug 24, 2026
QuncCccccc
left a comment
QuncCccccc
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thanks for porting it over:)
Contributor
Author
|
@QuncCccccc thanks for the review 🙂 |
Contributor
Author
|
@Piinks Thank you 😊 |
This was referenced Aug 25, 2026
zijiehe-google-com
pushed a commit
to zijiehe-google-com/flutter
that referenced
this pull request
Aug 25, 2026
…er#191734) flutter/packages@df2ba94...740f093 2026-08-25 [email protected] [cupertino_ui] Remove unused parameters from constructors of generic classes. (flutter/packages#12457) 2026-08-25 [email protected] [material_ui] Remove unused parameters from constructors of generic classes. (flutter/packages#12458) 2026-08-25 [email protected] Ignore shared code for iOS platform implementation of Google Maps plugin (flutter/packages#12529) 2026-08-25 [email protected] [cross_file] fixed `readAsString` decoding in-memory bytes as UTF-16 (flutter/packages#12479) 2026-08-25 [email protected] [cupertino_ui] Remove two items assert to allow CupertinoTabBar to have one tab (flutter/packages#12546) 2026-08-25 [email protected] [cupertino_ui] Fix covered sheet revealing root route through top gap (flutter/packages#12530) 2026-08-25 [email protected] Sync release-go_router-18.0.0 to main (flutter/packages#12575) 2026-08-25 [email protected] Sync release-material_ui-1.1.0 to main (flutter/packages#12577) 2026-08-25 [email protected] Sync release-cupertino_ui-1.0.1 to main (flutter/packages#12576) 2026-08-24 [email protected] [quick_actions_ios]unskip XCUITests (flutter/packages#12436) 2026-08-24 [email protected] Fix RangeSlider thumb overlay remains visible after touch interaction ends (flutter/packages#12560) 2026-08-24 [email protected] [google_sign_in] Increase iOS coverage tests (flutter/packages#12484) 2026-08-24 [email protected] [camera_android_camerax] Migrate from dart_skills_lint to skills_lint (flutter/packages#12543) 2026-08-24 [email protected] [go_router] Clarify onEnter/redirect ordering, add regression test (flutter/packages#12337) 2026-08-24 [email protected] [material_ui] Port flutter/flutter flutter#185149 "Slider label clips the screen" (flutter/packages#12572) 2026-08-24 [email protected] Roll Flutter from 65c9a8d to 9a82789 (17 revisions) (flutter/packages#12578) 2026-08-24 [email protected] [tool] Fix dart_test.yaml parsing (flutter/packages#12574) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
jagadeesh8682
pushed a commit
to jagadeesh8682/packages
that referenced
this pull request
Sep 2, 2026
… ends (flutter#12560) Ports flutter/flutter#189610 to material_ui, per the porting instructions in flutter/flutter#188444. Fixes flutter/flutter#189205 After a RangeSlider thumb was touched or dragged, the selected thumb could retain focus and continue painting the focused overlay after the touch gesture ended. This happened because the focused thumb requested keyboard focus during pointer interaction, and RangeSlider painted its focused overlay directly from FocusNode.hasFocus. This PR separates actual thumb focus from the visual focus highlight. Touch interaction can still move focus to the selected thumb for semantics and keyboard continuation, but the focused overlay is only painted when Flutter's focus highlight mode says it should be shown, such as keyboard/traditional focus. This PR also fixes the active drag overlay disappearing while a touch gesture is still in progress. Previously, if the finger moved outside the thumb's overlay bounds during a drag, hover tracking could reverse the shared overlay animation even though the slider was still active. The overlay now remains visible for the active drag and dismisses when the interaction ends. Original PR: flutter/flutter#189610 ## Pre-Review Checklist
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports flutter/flutter#189610 to material_ui, per the porting instructions in flutter/flutter#188444.
Fixes flutter/flutter#189205
After a RangeSlider thumb was touched or dragged, the selected thumb could retain focus and continue painting the focused overlay after the touch gesture ended. This happened because the focused thumb requested keyboard focus during pointer interaction, and RangeSlider painted its focused overlay directly from FocusNode.hasFocus.
This PR separates actual thumb focus from the visual focus highlight. Touch interaction can still move focus to the selected thumb for semantics and keyboard continuation, but the focused overlay is only painted when Flutter's focus highlight mode says it should be shown, such as keyboard/traditional focus.
This PR also fixes the active drag overlay disappearing while a touch gesture is still in progress. Previously, if the finger moved outside the thumb's overlay bounds during a drag, hover tracking could reverse the shared overlay animation even though the slider was still active. The overlay now remains visible for the active drag and dismisses when the interaction ends.
Original PR: flutter/flutter#189610
Pre-Review Checklist
[shared_preferences]///).