Repository navigation
[repo] Update AGENTS.md with dependency allowance and versioning guidance - #12579
Conversation
|
|
||
| ### Specialized Workflows | ||
|
|
||
| - **Allowed Dependencies in `.repo_tool_config.yaml`**: The repository strictly enforces a whitelist of non-local dependencies. If you add or modify a dependency in any package's `pubspec.yaml` (including `dev_dependencies`), ensure the package is registered under `allowed_dependencies` (either `pinned` or `unpinned`) in `.repo_tool_config.yaml` at the repository root. Otherwise, `validate` will fail with `The following unexpected non-local dependencies were found`. |
There was a problem hiding this comment.
FWIW I think instructing agents to add packages to the allow list is a very bad idea. The whole point of the allow list is to make a human have to take an extra step and think very carefully about whether it actually meets our requirements.
I would expect an agent to just blithely add entries given this, and a human may miss that change in all the diffs of a non-trivial PR.
I would suggest explicitly instructing agents never to add to this file, and to instead flag the need for a human to evaluate it in the PR description.
There was a problem hiding this comment.
Let me take a human pass at this text. Also I am sorry if this showed up on your review queue. I like to hand review any prs before adding reviewers. Did my agent add you or did you see it from some other process.
There was a problem hiding this comment.
Sorry, I just saw the title in the repo PR list and was curious. I should leave drafts alone 🙂
There was a problem hiding this comment.
That is fine I always want your perspective. I just want to limit my requests of your time to situations where I can make sure not to waste it. I asked my agent to author this pr in a sub agent while I was working on another task.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates AGENTS.md to clarify that the minimal version option bumps patches for non-breaking changes and adds instructions for requesting versioning and changelog overrides for internal changes. The review feedback suggests adding missing documentation regarding the requirement to whitelist external or Google-owned dependencies in .repo_tool_config.yaml when they are added or updated.
…er#193840) flutter/packages@5620e65...951f2f7 2026-10-05 [email protected] [material_ui] Add scrollPadding property to DropdownMenuFormField (flutter/packages#12735) 2026-10-02 [email protected] [material_ui] Migrate M3 Motion template to use new gen_defaults (flutter/packages#13058) 2026-10-02 [email protected] [cupertino_ui] Forward showDragHandle from showCupertinoSheet to CupertinoSheetRoute (flutter/packages#13011) 2026-10-02 [email protected] [cupertino_ui] Fix CupertinoMagnifier focal point with custom size (flutter/packages#13029) 2026-10-02 [email protected] [ci] Add material_ui and cupertino_ui to customer testing (flutter/packages#13114) 2026-10-02 [email protected] [material_ui] Add Material 3 Expressive migration skill (flutter/packages#12818) 2026-10-02 [email protected] [video_player] Ignore late position updates after disposal (flutter/packages#12971) 2026-10-02 [email protected] [material_ui] Remove unconditional dart:io import from about.dart (flutter/packages#12774) 2026-10-02 [email protected] [material_ui] Fix DropdownButtonFormField underline alignment at bottom (flutter/packages#12606) 2026-10-02 [email protected] Roll Flutter from e89fd0a to d03768e (23 revisions) (flutter/packages#13111) 2026-10-02 [email protected] [material_ui] Migrate `Switch` API doc snippets to {@example} (batch 8) (flutter/packages#13052) 2026-10-02 [email protected] [url_launcher] Fix supportsCloseForLaunchMode to query close support (flutter/packages#12926) 2026-10-02 [email protected] Redistribute iOS/macOS Suggested Reviewers (flutter/packages#13076) 2026-10-02 [email protected] [image_picker] Subsample large images when resizing on Android (flutter/packages#13038) 2026-10-02 [email protected] [cupertino_ui] Remove redundant null arguments in Completer.complete (flutter/packages#13008) 2026-10-02 [email protected] [repo] Update AGENTS.md with dependency allowance and versioning guidance (flutter/packages#12579) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
4 participants
Updates
AGENTS.mdto add guidance on common presubmit validation requirements:pubspec.yamlor tool configs) triggers version andCHANGELOG.mdrequirements during repository validation unless explicit override labels are requested.Pre-Review Checklist
[shared_preferences]///).