Repository navigation
[cupertino_ui] Forward showDragHandle from showCupertinoSheet to CupertinoSheetRoute - #13011
Merged
auto-submit[bot] merged 3 commits intoOct 2, 2026
Conversation
showCupertinoSheet accepts a showDragHandle parameter but never passed it to the CupertinoSheetRoute it constructs, in either the plain or the useNestedNavigation branch. Since CupertinoSheetRoute.showDragHandle defaults to false, the value was silently dropped and no drag handle was rendered, even though pushing CupertinoSheetRoute directly with the same flag shows one. Fixes flutter/flutter#187693
github-actions
Bot
added
p: cupertino_ui
triage-design
10 tasks done
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates showCupertinoSheet in packages/cupertino_ui to forward the showDragHandle parameter to CupertinoSheetRoute. It also adds a corresponding widget test to verify this behavior and includes a pending changelog entry. I have no feedback to provide.
navaronbracke
approved these changes
Sep 25, 2026
Piinks
added
CICD
This was referenced Oct 5, 2026
ZhuJHua
pushed a commit
to ZhuJHua/flutter
that referenced
this pull request
Oct 6, 2026
…er#193840) flutter/packages@5620e65...951f2f7 2026-10-05 [email protected] [material_ui] Add scrollPadding property to DropdownMenuFormField (flutter/packages#12735) 2026-10-02 [email protected] [material_ui] Migrate M3 Motion template to use new gen_defaults (flutter/packages#13058) 2026-10-02 [email protected] [cupertino_ui] Forward showDragHandle from showCupertinoSheet to CupertinoSheetRoute (flutter/packages#13011) 2026-10-02 [email protected] [cupertino_ui] Fix CupertinoMagnifier focal point with custom size (flutter/packages#13029) 2026-10-02 [email protected] [ci] Add material_ui and cupertino_ui to customer testing (flutter/packages#13114) 2026-10-02 [email protected] [material_ui] Add Material 3 Expressive migration skill (flutter/packages#12818) 2026-10-02 [email protected] [video_player] Ignore late position updates after disposal (flutter/packages#12971) 2026-10-02 [email protected] [material_ui] Remove unconditional dart:io import from about.dart (flutter/packages#12774) 2026-10-02 [email protected] [material_ui] Fix DropdownButtonFormField underline alignment at bottom (flutter/packages#12606) 2026-10-02 [email protected] Roll Flutter from e89fd0a to d03768e (23 revisions) (flutter/packages#13111) 2026-10-02 [email protected] [material_ui] Migrate `Switch` API doc snippets to {@example} (batch 8) (flutter/packages#13052) 2026-10-02 [email protected] [url_launcher] Fix supportsCloseForLaunchMode to query close support (flutter/packages#12926) 2026-10-02 [email protected] Redistribute iOS/macOS Suggested Reviewers (flutter/packages#13076) 2026-10-02 [email protected] [image_picker] Subsample large images when resizing on Android (flutter/packages#13038) 2026-10-02 [email protected] [cupertino_ui] Remove redundant null arguments in Completer.complete (flutter/packages#13008) 2026-10-02 [email protected] [repo] Update AGENTS.md with dependency allowance and versioning guidance (flutter/packages#12579) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of flutter/flutter#187803 to
cupertino_ui, following the process in flutter/flutter#188444. The original PR was approved by dkwingsmt and navaronbracke but couldn't land because of the Material/Cupertino code freeze.showCupertinoSheetaccepts ashowDragHandleparameter and documents what it does, but never passes it to theCupertinoSheetRouteit builds — so setting it totruehas no effect. This forwards it on both paths (the plain route and the nested-navigation route).The regression test calls
showCupertinoSheet(showDragHandle: true)and checks the drag handle is actually rendered. I checked that it fails with the forwarding removed and passes with it, in its new location underpackages/cupertino_ui/test/.The original commit was cherry-picked as the porting guide describes. It hit one conflict: since the copy,
mainaddedhasPlatformViews: hasPlatformViewsto the same twoCupertinoSheetRouteconstructor calls. I resolved it by keeping both arguments; the bug itself is still present onmain(showDragHandleis declared but never forwarded). The only new commit adds the pending changelog entry (version: patch).Fixes flutter/flutter#187693
Pre-Review Checklist
[shared_preferences]///).I used AI tooling while working on this, and reviewed and tested all of it myself.
Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2