Skip to content

[material_ui] Add labelTextDirection handling in InputDecorator - #12607

Merged
auto-submit[bot] merged 16 commits into
flutter:mainfrom
Mairramer:feat/unified-input-text-direction
Sep 25, 2026
Merged

auto-submit[bot] merged 16 commits into
flutter:mainfrom
Mairramer:feat/unified-input-text-direction

Conversation

@Mairramer

Copy link
Copy Markdown
Contributor

This PR introduces labelTextDirection property to InputDecoration.

Closes flutter/flutter#41324

Port of flutter/flutter#182477

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2

@github-actions github-actions Bot added p: material_ui triage-design Should be looked at in design triage labels Aug 25, 2026
@Mairramer Mairramer changed the title Feat/unified input text direction [material_ui] Add labelTextDirection handling in InputDecorator Aug 25, 2026
@Mairramer Mairramer added the CICD Run CI/CD label Sep 24, 2026
@Mairramer
Mairramer marked this pull request as ready for review September 24, 2026 12:41

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a labelTextDirection property to InputDecoration to allow explicit control over the text direction of the label. It updates the InputDecorator to apply this direction to the label text, adds documentation to TextField regarding text direction behavior, includes a changelog entry, and adds a test case to verify the new functionality. I have no feedback to provide.

@Renzo-Olivares Renzo-Olivares left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo a small comment, thanks for the contribution and for porting it over to the new packages repo!

Comment thread packages/material_ui/lib/src/input_decorator.dart Outdated
@flutter-dashboard flutter-dashboard Bot removed the CICD Run CI/CD label Sep 25, 2026
@Mairramer Mairramer added the CICD Run CI/CD label Sep 25, 2026
@flutter-dashboard flutter-dashboard Bot removed the CICD Run CI/CD label Sep 25, 2026
@Mairramer Mairramer added CICD Run CI/CD autosubmit Merge PR when tree becomes green via auto submit App labels Sep 25, 2026
@auto-submit
auto-submit Bot merged commit e55e7ac into flutter:main Sep 25, 2026
14 checks passed
pull Bot pushed a commit to fucheng-guo-sun/flutter that referenced this pull request Sep 25, 2026
…r#193351)

flutter/packages@431ea69...e55e7ac

2026-09-25 [email protected] [material_ui] Add
labelTextDirection handling in InputDecorator (flutter/packages#12607)
2026-09-24 [email protected] [pigeon] Fix NSnumber edge cases and
null value bug (flutter/packages#12997)
2026-09-24 [email protected] [camera] add
custom path ouput to recording (flutter/packages#11774)
2026-09-24 [email protected] [Android 17] Update packages CI test
runners to SDK 37 (flutter/packages#12376)
2026-09-24 [email protected]
[pigeon][video_player] Disable `video_player` and `pigeon` flakes
blocking latest flutter -> packages roll (flutter/packages#13003)
2026-09-24 [email protected]
[google_maps_flutter] Add onPointOfInterestTap platform implementations
(flutter/packages#12880)

If this roll has caused a breakage, revert this CL and set the roller
to dry run mode using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD p: material_ui triage-design Should be looked at in design triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TextField/TextFormField labelText and hintText should be right-aligned with TextDirection.rtl

2 participants