Repository navigation
[pigeon][video_player] Disable video_player and pigeon flakes blocking latest flutter -> packages roll - #13003
Merged
Conversation
elliette
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates integration tests to skip flaky or hanging tests on macOS. Specifically, the 'event channels handle multiple instances' test in Pigeon is skipped for macOS Swift, and a video player integration test is skipped on macOS. There are no review comments, and I have no feedback to provide.
elliette
changed the title
video_player and pigeon flakes blocking latest flutter -> packages roll
tarrinneal
approved these changes
Sep 24, 2026
elliette
added
emergency
|
Detected the If you add the The "Merge" button is also unlocked. To bypass presubmits as well as the tree status, press the GitHub "Add to Merge Queue". |
pull Bot
pushed a commit
to fucheng-guo-sun/flutter
that referenced
this pull request
Sep 25, 2026
…r#193351) flutter/packages@431ea69...e55e7ac 2026-09-25 [email protected] [material_ui] Add labelTextDirection handling in InputDecorator (flutter/packages#12607) 2026-09-24 [email protected] [pigeon] Fix NSnumber edge cases and null value bug (flutter/packages#12997) 2026-09-24 [email protected] [camera] add custom path ouput to recording (flutter/packages#11774) 2026-09-24 [email protected] [Android 17] Update packages CI test runners to SDK 37 (flutter/packages#12376) 2026-09-24 [email protected] [pigeon][video_player] Disable `video_player` and `pigeon` flakes blocking latest flutter -> packages roll (flutter/packages#13003) 2026-09-24 [email protected] [google_maps_flutter] Add onPointOfInterestTap platform implementations (flutter/packages#12880) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work towards flutter/flutter#193291, flutter/flutter#179154, flutter/flutter#193300
Disables the
pigeonandvideo_playerflakes that manifested on the most recent flutter -> packages autoroll (#12999)Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2