Skip to content

[cupertino_icons] Migrate to cupertino_ui - #12649

Merged
auto-submit[bot] merged 1 commit into
flutter:mainfrom
ricardodalarme:refactor/decouple-migrate-cupertino_icons
Sep 29, 2026
Merged

auto-submit[bot] merged 1 commit into
flutter:mainfrom
ricardodalarme:refactor/decouple-migrate-cupertino_icons

Conversation

@ricardodalarme

@ricardodalarme ricardodalarme commented Aug 27, 2026 •

Copy link
Copy Markdown
Contributor

Update cupertino_icons to use cupertino_ui instead of flutter/cupertino

Part of #flutter/flutter#191322

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2

@github-actions github-actions Bot added p: cupertino_icons triage-design Should be looked at in design triage labels Aug 27, 2026
@ricardodalarme ricardodalarme changed the title refactor(cupertino_icons): migrate to use cupertino_ui instead of flu… refactor(cupertino_icons): migrate to use cupertino_ui instead of flutter/cupertino Aug 27, 2026
@ricardodalarme ricardodalarme changed the title refactor(cupertino_icons): migrate to use cupertino_ui instead of flutter/cupertino [cupertino_icons] Use cupertino_ui instead of flutter/cupertino Aug 27, 2026
@ricardodalarme ricardodalarme changed the title [cupertino_icons] Use cupertino_ui instead of flutter/cupertino [cupertino_icons] Migrate to cupertino_ui Aug 27, 2026
@ricardodalarme
ricardodalarme marked this pull request as ready for review August 27, 2026 14:07

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the minimum supported Dart SDK version to 3.12.0 and migrates tests to use cupertino_ui instead of flutter/cupertino.dart. Feedback was provided to add the missing Flutter SDK constraint to the environment block in pubspec.yaml to ensure consistency with the updated minimum supported version stated in the changelog.

Comment thread third_party/packages/cupertino_icons/pubspec.yaml
@elliette

Copy link
Copy Markdown
Member

[from triage] gentle ping @dkwingsmt

@ricardodalarme
ricardodalarme force-pushed the refactor/decouple-migrate-cupertino_icons branch from d16b301 to 85617e8 Compare September 25, 2026 15:50

@dkwingsmt dkwingsmt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ricardodalarme

Copy link
Copy Markdown
Contributor Author

@dkwingsmt what's next? should I wait for a second review?

@Piinks Piinks added the CICD Run CI/CD label Sep 28, 2026

@victorsanni victorsanni left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is failing the linux repo checks check, can you apply fixes so this can land?

@ricardodalarme
ricardodalarme force-pushed the refactor/decouple-migrate-cupertino_icons branch from 85617e8 to 147f2b4 Compare September 28, 2026 22:21
@flutter-dashboard flutter-dashboard Bot removed the CICD Run CI/CD label Sep 28, 2026
@ricardodalarme
ricardodalarme force-pushed the refactor/decouple-migrate-cupertino_icons branch from 147f2b4 to 682be20 Compare September 28, 2026 22:24
@ricardodalarme

Copy link
Copy Markdown
Contributor Author

Fixed @victorsanni. I also updated the package version to v2.0.0

@ricardodalarme
ricardodalarme force-pushed the refactor/decouple-migrate-cupertino_icons branch from 682be20 to 165770c Compare September 29, 2026 02:23
@dkwingsmt dkwingsmt added CICD Run CI/CD autosubmit Merge PR when tree becomes green via auto submit App labels Sep 29, 2026
@auto-submit
auto-submit Bot merged commit 3c6ce59 into flutter:main Sep 29, 2026
13 checks passed
pull Bot pushed a commit to g-star1024/flutter that referenced this pull request Sep 29, 2026
…er#193507)

flutter/packages@ba0364a...3c6ce59

2026-09-29 [email protected] [cupertino_icons] Migrate to
`cupertino_ui` (flutter/packages#12649)
2026-09-29 [email protected] Manual roll Flutter from
4fcd90b to c5a061b (222 revisions) (flutter/packages#13060)
2026-09-28 [email protected] Enable Built-in Kotlin in all Flutter
Android Plugin Example Apps (flutter/packages#12883)
2026-09-28 [email protected] Enable Built-in Kotlin for
`interactive_media_ads` (flutter/packages#12912)
2026-09-28 [email protected] [google_maps_flutter] Adopt Pigeon's
Kotlin 'suspend' support (flutter/packages#12980)
2026-09-28 [email protected] [material_ui] Fix floating-point
rounding errors for discrete Slider and RangeSlider
(flutter/packages#13022)
2026-09-28 [email protected] [google_sign_in] PR 4/4 Convert
the Pigeon host API from Objective-C to Swift (flutter/packages#12658)
2026-09-28 [email protected]
[google_maps_flutter] Disable flaky web tests blocking latest flutter ->
packages roll (flutter/packages#13047)
2026-09-28 [email protected] [material_ui] Add fontFeatures and
fontVariations to TextTheme.apply() (flutter/packages#12879)
2026-09-28 [email protected]
[in_app_purchase_storekit] Disable flaky tests blocking latest flutter
-> packages roll (flutter/packages#13048)
2026-09-28 [email protected] Sync release-material_ui-1.5.0 to
main (flutter/packages#13051)
2026-09-28 [email protected] Sync release-go_router-18.0.2 to
main (flutter/packages#13050)
2026-09-28 [email protected] [google_fonts] Migrate to material_ui &
cupertino_ui (flutter/packages#13006)
2026-09-28 [email protected] [go_router_builder] Reland material_ui
migration (flutter/packages#12995)

If this roll has caused a breakage, revert this CL and set the roller
to dry run mode using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD p: cupertino_icons triage-design Should be looked at in design triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants