Repository navigation
[tool] Exempt AGENTS.md from version and changelog checks - #12681
Merged
auto-submit[bot] merged 1 commit intoAug 31, 2026
Merged
auto-submit[bot] merged 1 commit into
auto-submit[bot] merged 1 commit into
Conversation
Exempts AGENTS.md from triggering missing CHANGELOG and version bump errors in flutter_plugin_tools validate, adds AGENTS.md as a package support file, and adds it to .pubignore in camera_android_camerax.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request exempts AGENTS.md from requiring version and changelog changes by updating file filters and package state utilities to recognize it as a package support and dev-facing file. It also adds corresponding unit tests and updates .pubignore for the camera_android_camerax package. There are no review comments, and I have no feedback to provide.
Contributor
|
Convert to draft until tests pass. |
reidbaker
approved these changes
Aug 28, 2026
Contributor
There was a problem hiding this comment.
Code Review
This pull request exempts AGENTS.md files from requiring version and changelog changes. It updates the tooling to recognize AGENTS.md as a package support file and a dev-facing change, and adds corresponding unit tests to verify this behavior. There are no review comments to address.
reidbaker
added
override: no versioning needed
Contributor
|
Ironically the labels are needed on this pr because pubignore is not an excluded file. I think that is correct because if the ignore changes caused added files for a release then you probably do want a new version. |
stuartmorgan-g
approved these changes
Aug 31, 2026
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
Collaborator
There was a problem hiding this comment.
LGTM
I'd be fine with exempting .pubignore FWIW; I imagine that removing things from pubignore to add them to a release is going to be a very rare use case, and presumably not one where people would forget to add a version if they were trying to release.
reidbaker
added
the
autosubmit
This was referenced Sep 1, 2026
pull Bot
pushed a commit
to g-star1024/flutter
that referenced
this pull request
Sep 1, 2026
…r#192119) flutter/packages@d642322...7a7912f 2026-09-01 [email protected] [material_ui] Migrate AppBar M3 template to use new gen_defaults script (flutter/packages#12707) 2026-09-01 [email protected] [vector_graphics] Fix deprecation lints (flutter/packages#12702) 2026-08-31 [email protected] [material_ui] Standardize M3 and M3E token template base class names (flutter/packages#12675) 2026-08-31 [email protected] [vector_graphics_compiler] Fix deprecation issues in tests (flutter/packages#12700) 2026-08-31 [email protected] [google_maps_flutter] Convert marker controllers to Swift (flutter/packages#12662) 2026-08-31 [email protected] [material_ui, cupertino_ui, go_router] Command to test dart fixes (flutter/packages#12390) 2026-08-31 [email protected] Roll Flutter from c978386 to c8c5e3b (4 revisions) (flutter/packages#12706) 2026-08-31 [email protected] [tool] Exempt AGENTS.md from version and changelog checks (flutter/packages#12681) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni
pushed a commit
to victorsanni/packages
that referenced
this pull request
Sep 9, 2026
) This came up as part of flutter#12668 which needed the labels. This pr excludes AGENTS.md from both pub publishing and from needing changelog/version requirements. - @reidbaker Agent authored description --- Exempts `AGENTS.md` from requiring CHANGELOG updates and version bumps in package validation, adds `AGENTS.md` as a package support file in repo tooling, and adds `AGENTS.md` to `.pubignore` in `camera_android_camerax`. ## Summary - **Repository Tooling**: - `script/tool/lib/src/common/package_state_utils.dart`: Added `pathComponents.last == 'AGENTS.md'` to `_isDevChange` so developer/agent guidelines in `AGENTS.md` do not trigger missing CHANGELOG or version bump errors. - `script/tool/lib/src/common/file_filters.dart`: Added `path.endsWith('/AGENTS.md')` to `isPackageSupportFile`. - `script/tool/CHANGELOG.md`: Added changelog entry under `## NEXT`. - **Package `.pubignore`**: - `packages/camera/camera_android_camerax/.pubignore`: Added `AGENTS.md` to prevent publishing agent guidelines to pub.dev. - **Tests**: - Added unit tests in `script/tool/test/common/package_state_utils_test.dart`, `script/tool/test/common/file_filters_test.dart`, and `script/tool/test/validate_command_version_test.dart`. ## Pre-Review Checklist
victorsanni
pushed a commit
to victorsanni/packages
that referenced
this pull request
Sep 9, 2026
) This came up as part of flutter#12668 which needed the labels. This pr excludes AGENTS.md from both pub publishing and from needing changelog/version requirements. - @reidbaker Agent authored description --- Exempts `AGENTS.md` from requiring CHANGELOG updates and version bumps in package validation, adds `AGENTS.md` as a package support file in repo tooling, and adds `AGENTS.md` to `.pubignore` in `camera_android_camerax`. ## Summary - **Repository Tooling**: - `script/tool/lib/src/common/package_state_utils.dart`: Added `pathComponents.last == 'AGENTS.md'` to `_isDevChange` so developer/agent guidelines in `AGENTS.md` do not trigger missing CHANGELOG or version bump errors. - `script/tool/lib/src/common/file_filters.dart`: Added `path.endsWith('/AGENTS.md')` to `isPackageSupportFile`. - `script/tool/CHANGELOG.md`: Added changelog entry under `## NEXT`. - **Package `.pubignore`**: - `packages/camera/camera_android_camerax/.pubignore`: Added `AGENTS.md` to prevent publishing agent guidelines to pub.dev. - **Tests**: - Added unit tests in `script/tool/test/common/package_state_utils_test.dart`, `script/tool/test/common/file_filters_test.dart`, and `script/tool/test/validate_command_version_test.dart`. ## Pre-Review Checklist
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This came up as part of #12668 which needed the labels. This pr excludes AGENTS.md from both pub publishing and from needing changelog/version requirements.
Agent authored description
Exempts
AGENTS.mdfrom requiring CHANGELOG updates and version bumps in package validation, addsAGENTS.mdas a package support file in repo tooling, and addsAGENTS.mdto.pubignoreincamera_android_camerax.Summary
script/tool/lib/src/common/package_state_utils.dart: AddedpathComponents.last == 'AGENTS.md'to_isDevChangeso developer/agent guidelines inAGENTS.mddo not trigger missing CHANGELOG or version bump errors.script/tool/lib/src/common/file_filters.dart: Addedpath.endsWith('/AGENTS.md')toisPackageSupportFile.script/tool/CHANGELOG.md: Added changelog entry under## NEXT..pubignore:packages/camera/camera_android_camerax/.pubignore: AddedAGENTS.mdto prevent publishing agent guidelines to pub.dev.script/tool/test/common/package_state_utils_test.dart,script/tool/test/common/file_filters_test.dart, andscript/tool/test/validate_command_version_test.dart.Pre-Review Checklist