Repository navigation
[google_maps_flutter_platform_interface] Add onPointOfInterestTap support - #12752
Merged
auto-submit[bot] merged 2 commits intoSep 15, 2026
Merged
Conversation
11 tasks done
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds support for tapping points of interest (POIs) on the map by introducing PointOfInterestId, PointOfInterestTapEvent, and the onPointOfInterestTap stream. Feedback suggests enhancing the API by creating a PointOfInterest class that includes the POI's name and coordinates, rather than just its ID. Additionally, it is recommended to throw an UnimplementedError in the default implementation of onPointOfInterestTap to maintain consistency with other platform interface methods, and to update the corresponding tests accordingly.
…port Add PointOfInterestId, PointOfInterestTapEvent, and a default empty onPointOfInterestTap stream so implementations can opt in without a breaking platform-interface change.
tenninebt
force-pushed
the
google-maps-poi-platform-interface
branch
from
September 4, 2026 16:08
4b55349 to
a0bb5d2
Compare
stuartmorgan-g
approved these changes
Sep 9, 2026
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
Collaborator
There was a problem hiding this comment.
LGTM!
@tarrinneal or @bparrishMines for secondary review
stuartmorgan-g
added
CICD
dkwingsmt
pushed a commit
to dkwingsmt/flutter
that referenced
this pull request
Sep 15, 2026
…r#192809) flutter/packages@9caa77c...bebbb57 2026-09-15 [email protected] [google_maps_flutter_platform_interface] Add onPointOfInterestTap support (flutter/packages#12752) 2026-09-14 [email protected] [google_maps_flutter] Adopts new async/await Swift Pigeon support (flutter/packages#12860) 2026-09-14 [email protected] [material_ui] Fix `todayBorder` color being overridden by `todayForegroundColor` in `YearPicker` (flutter/packages#12697) 2026-09-13 [email protected] Roll Flutter from 2553f89 to 8b3e8f5 (4 revisions) (flutter/packages#12856) 2026-09-12 [email protected] [google_maps_flutter] Convert remaining code to Swift (flutter/packages#12768) 2026-09-12 [email protected] Roll Flutter from 63b9518 to 2553f89 (62 revisions) (flutter/packages#12855) 2026-09-12 [email protected] Roll Flutter (stable) from d3b14c8 to 9584c67 (15 revisions) (flutter/packages#12854) 2026-09-12 [email protected] [material_ui] Update gen_defaults color helper (flutter/packages#12846) 2026-09-11 [email protected] [material_ui] Port flutter/flutter flutter#185475 "Accessibility: Add semanticLabel to MenuAnchor" (flutter/packages#12806) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This was referenced Sep 15, 2026
Contributor
Author
|
🥳 |
This was referenced Sep 15, 2026
auto-submit Bot
pushed a commit
that referenced
this pull request
Sep 24, 2026
…ns (#12880) ## Summary - Platform implementations of `onPointOfInterestTap` for **Android**, **iOS** (`sdk9` / `sdk10` + shared source), and **web** - Depends on published `google_maps_flutter_platform_interface` 2.17.0 from #12752 - Federated implementations PR (per [Changing federated plugins](https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changing-federated-plugins)); app-facing package will follow in a separate PR **Notes** - Frozen `google_maps_flutter_ios` is intentionally unchanged (no new features per that package’s README); iOS support is in `google_maps_flutter_ios_sdk9` / `google_maps_flutter_ios_sdk10` - iOS DI follows the Swift controller conventions (required `callbackHandler` on the designated initializer) Supersedes the separate drafts #12881 (web) and #12882 (iOS). Part of #11872 / flutter/flutter#60695. ## Pre-Review Checklist
11 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the platform interface portion of #11872
Adds
PointOfInterestId,PointOfInterestTapEvent, andGoogleMapsFlutterPlatform.onPointOfInterestTap. The default implementation returns an empty stream so existing platform implementations are not broken.Fixes flutter/flutter#60695 (platform interface only; app-facing and implementation packages land in follow-up PRs per the federated plugin contribution process).
Pre-Review Checklist
[shared_preferences]///).@stuartmorgan-g — this is the first sub-PR from #11872 as requested.