Repository navigation
[google_maps_flutter] Convert remaining code to Swift - #12768
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request converts the remaining Objective-C code to Swift for both the google_maps_flutter_ios_sdk9 and google_maps_flutter_ios_sdk10 packages. This includes updating the Pigeon configuration to generate Swift code, removing Objective-C files, and refactoring Swift implementation and test files to use the new Swift-generated Pigeon APIs. Two minor typos were identified in the changelog files.
11 tasks done
hellohuanlin
approved these changes
Sep 10, 2026
| func clusters(withIdentifier identifier: String) throws -> [PlatformCluster] { | ||
| guard let clusterManager = clusterManagerIdentifierToManagers[identifier] else { | ||
| error.pointee = FlutterError( | ||
| throw PigeonError( |
Contributor
There was a problem hiding this comment.
nice, just curious, was the error.pointee from the objc pigeon?
Collaborator
Author
There was a problem hiding this comment.
Yes, the AutoreleasingUnsafeMutablePointer<FlutterError?> error is the Swift expression of the Obj-C error out param object pattern (with FlutterError** in this case instead of NSError**).
| return GMUGradient( | ||
| colors: colors, | ||
| startPoints: startPoints, | ||
| startPoints: startPoints.map({ $0 as NSNumber }), |
Contributor
There was a problem hiding this comment.
nit: startPoints.map { $0 as NSNumber }
Collaborator
Author
There was a problem hiding this comment.
Fixed for all instances of map({ ... }) (there were some from the previous PRs in this sequence as well).
stuartmorgan-g
force-pushed
the
maps-swift-final
branch
from
September 12, 2026 19:57
656237f to
3f81041
Compare
stuartmorgan-g
added
the
autosubmit
This was referenced Sep 14, 2026
dkwingsmt
pushed a commit
to dkwingsmt/flutter
that referenced
this pull request
Sep 15, 2026
…r#192809) flutter/packages@9caa77c...bebbb57 2026-09-15 [email protected] [google_maps_flutter_platform_interface] Add onPointOfInterestTap support (flutter/packages#12752) 2026-09-14 [email protected] [google_maps_flutter] Adopts new async/await Swift Pigeon support (flutter/packages#12860) 2026-09-14 [email protected] [material_ui] Fix `todayBorder` color being overridden by `todayForegroundColor` in `YearPicker` (flutter/packages#12697) 2026-09-13 [email protected] Roll Flutter from 2553f89 to 8b3e8f5 (4 revisions) (flutter/packages#12856) 2026-09-12 [email protected] [google_maps_flutter] Convert remaining code to Swift (flutter/packages#12768) 2026-09-12 [email protected] Roll Flutter from 63b9518 to 2553f89 (62 revisions) (flutter/packages#12855) 2026-09-12 [email protected] Roll Flutter (stable) from d3b14c8 to 9584c67 (15 revisions) (flutter/packages#12854) 2026-09-12 [email protected] [material_ui] Update gen_defaults color helper (flutter/packages#12846) 2026-09-11 [email protected] [material_ui] Port flutter/flutter flutter#185475 "Accessibility: Add semanticLabel to MenuAnchor" (flutter/packages#12806) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts remaining code to Swift:
NSObjectconformance from cases where it's no longer necessary. (Class that implement Flutter plugin API protocols still need it, as those are Obj-C protocols.)Unlike the other PRs, this does not contain any Gemini Obj-C -> Swift conversions (other than some simple protocols); this is mostly just a Pigeon generation change and a lot of mostly mechanical cleanup.
Fixes flutter/flutter#119108
Pre-Review Checklist
[shared_preferences]///).Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2