Repository navigation
[material_ui] Repaint NavigationIndicator when the selection changes without pointer input - #13010
Merged
auto-submit[bot] merged 3 commits intoOct 2, 2026
Conversation
NavigationIndicator draws its background with an Ink widget, which paints on the nearest ancestor Material rather than on its own render object. When the selected index changes without a pointer interaction (for example, programmatically alongside an IndexedStack), nothing notifies that Material, so it keeps showing the indicator's previous frame; in a NavigationDrawer the highlight visibly sticks to the old destination until a hover, click, or resize forces a repaint. Notify the indicator's MaterialInkController whenever the indicator animation ticks, the same way ink features such as InkHighlight request repaints when their state changes. Fixes flutter/flutter#180359
github-actions
Bot
added
p: material_ui
triage-design
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request fixes an issue where the NavigationIndicator fails to repaint when the selected index changes programmatically without pointer interaction. This is resolved by calling Material.of(context).markNeedsPaint() when the animation ticks. A regression test has been added to navigation_drawer_test.dart to verify that the hosting Material is marked as needing paint when the index changes, and a pending changelog entry has been created. There are no review comments, and I have no feedback to provide.
elliette
approved these changes
Oct 1, 2026
elliette
left a comment
elliette
left a comment
Member
There was a problem hiding this comment.
LGTM! Thanks for porting this over. Adding the original reviewers for a secondary review.
QuncCccccc
approved these changes
Oct 1, 2026
QuncCccccc
left a comment
QuncCccccc
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thanks for your contribution:)!
dkwingsmt
added
the
autosubmit
jesswrd
pushed a commit
to jesswrd/flutter
that referenced
this pull request
Oct 2, 2026
…er#193711) flutter/packages@d5ec6db...5620e65 2026-10-02 [email protected] [material_ui] Migrate M3 Menu template to use new gen_defaults (flutter/packages#13057) 2026-10-02 [email protected] [material_ui] Repaint NavigationIndicator when the selection changes without pointer input (flutter/packages#13010) 2026-10-01 [email protected] [tool] Use flutter pub for packages that depend on jni (flutter/packages#13087) 2026-10-01 [email protected] [material_ui] Migrate M3 snackbar defaults to new gen_defaults (flutter/packages#13009) 2026-10-01 [email protected] Manual roll Flutter (stable) from 6a19cca to 5fc3468 (6 revisions) (flutter/packages#13105) 2026-10-01 [email protected] Manual roll Flutter from d649d2b to e89fd0a (27 revisions) (flutter/packages#13104) 2026-10-01 [email protected] [webview_flutter] Add gesture blocking policy to WebKitWebViewWidgetCreationParams (flutter/packages#12496) 2026-10-01 [email protected] [material_ui] Update Material tokens to Material version 38.2.83 (flutter/packages#13082) 2026-10-01 [email protected] [material_ui] Migrate MaterialApp API doc snippets to {@example} and add unit tests (batch 6) (flutter/packages#13021) 2026-10-01 [email protected] [material_ui] Migrate AppBar, SliverAppBar, BottomAppBar, and Scaffold API doc snippets to {@example} (batch 7) (flutter/packages#13023) 2026-10-01 [email protected] [various] Update Robolectric to 4.17 (flutter/packages#13041) 2026-10-01 [email protected] [pigeon] pin native interop related dev deps and update some docs (flutter/packages#13103) 2026-10-01 [email protected] [tool] Add more documentation (flutter/packages#13063) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of flutter/flutter#187802 to
material_ui, following the process in flutter/flutter#188444. The original PR was approved by dkwingsmt and QuncCccccc but couldn't land because of the Material/Cupertino code freeze.NavigationIndicatordraws its indicator with anInk, which paints on the nearest ancestorMaterialrather than locally. When the indicator animates without an accompanying pointer interaction — for example whenselectedIndexis changed programmatically — nothing tells thatMaterialto repaint, so it keeps showing the indicator's previous frame. The fix callsMaterial.of(context).markNeedsPaint()on each animation tick.The regression test pumps a
NavigationDrawer, changesselectedIndexfrom outside without any pointer events, and verifies the indicator repaints. I checked it fails with the one-line fix removed and passes with it, in its new location underpackages/material_ui/test/.The two original commits were cherry-picked without merge commits, as the porting guide describes; rename detection placed them at
lib/src/navigation_bar.dartandtest/navigation_drawer_test.dartwith no conflicts. The only new commit adds the pending changelog entry (version: patch).Fixes flutter/flutter#180359
Pre-Review Checklist
[shared_preferences]///).I used AI tooling while working on this, and reviewed and tested all of it myself.
Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2