Repository navigation
[tool] Use flutter pub for packages that depend on jni - #13087
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the flutter_plugin_tools to ensure that packages depending on jni are correctly identified as requiring flutter pub. It introduces a helper function _requiresFlutterForPub to check for jni in dependencies or dev_dependencies, adds relevant tests, and updates the package version. A suggestion was provided to optimize the dependency check by using containsKey for better performance.
…utter-requiring packages
loic-sharma
approved these changes
Oct 1, 2026
tarrinneal
added
the
autosubmit
auto-submit
Bot
removed
the
autosubmit
Contributor
|
autosubmit label was removed for flutter/packages/13087, because - The status or check suite Dashboard Checks has failed. Please fix the issues identified (or deflake) before re-applying this label. |
tarrinneal
added
the
autosubmit
jesswrd
pushed a commit
to jesswrd/flutter
that referenced
this pull request
Oct 2, 2026
…er#193711) flutter/packages@d5ec6db...5620e65 2026-10-02 [email protected] [material_ui] Migrate M3 Menu template to use new gen_defaults (flutter/packages#13057) 2026-10-02 [email protected] [material_ui] Repaint NavigationIndicator when the selection changes without pointer input (flutter/packages#13010) 2026-10-01 [email protected] [tool] Use flutter pub for packages that depend on jni (flutter/packages#13087) 2026-10-01 [email protected] [material_ui] Migrate M3 snackbar defaults to new gen_defaults (flutter/packages#13009) 2026-10-01 [email protected] Manual roll Flutter (stable) from 6a19cca to 5fc3468 (6 revisions) (flutter/packages#13105) 2026-10-01 [email protected] Manual roll Flutter from d649d2b to e89fd0a (27 revisions) (flutter/packages#13104) 2026-10-01 [email protected] [webview_flutter] Add gesture blocking policy to WebKitWebViewWidgetCreationParams (flutter/packages#12496) 2026-10-01 [email protected] [material_ui] Update Material tokens to Material version 38.2.83 (flutter/packages#13082) 2026-10-01 [email protected] [material_ui] Migrate MaterialApp API doc snippets to {@example} and add unit tests (batch 6) (flutter/packages#13021) 2026-10-01 [email protected] [material_ui] Migrate AppBar, SliverAppBar, BottomAppBar, and Scaffold API doc snippets to {@example} (batch 7) (flutter/packages#13023) 2026-10-01 [email protected] [various] Update Robolectric to 4.17 (flutter/packages#13041) 2026-10-01 [email protected] [pigeon] pin native interop related dev deps and update some docs (flutter/packages#13103) 2026-10-01 [email protected] [tool] Add more documentation (flutter/packages#13063) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
9 of 11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
pub_utils.dartto useflutter pubinstead ofdart pubwhen a non-Flutter package (or its example) depends onjniindependenciesordev_dependencies.package:jnideclares aflutterconstraint in itspubspec.yamlenvironmentsection, which causesdart pub(includingdart pub publish) to fail version solving whenFLUTTER_ROOTis not set in the environment—even for non-Flutter Dart packages likepigeonthat only depend onjniindev_dependenciesand run unit tests withdart test. Scoping this check topub_utils.dartensurespubcommands useflutter pubwhiledart-testcontinues to usedart run test.If more packages run across this problem, they will need to be added to the list to force the
flutter pubcommand.Fixes flutter/flutter#192709
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2