Repository navigation
[image_picker] moves Android 13 image picker to options - #3370
Merged
Merged
Conversation
DanMossa
reviewed
Mar 4, 2023
stuartmorgan-g
requested changes
Mar 5, 2023
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
Collaborator
There was a problem hiding this comment.
Rather than have this Android-specific option in all of the APIs, I would rather we restrict this to the Android package. Since I doubt anyone is going to want different versions for different calls within the same app, the simplest option for clients would be a class-level setting, which we can put on the Android implementation in this case.
See https://pub.dev/packages/google_maps_flutter_android#display-mode for an example of what a platform class option looks like.
Contributor
Author
This is very helpful, thank you |
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
Collaborator
There was a problem hiding this comment.
Thanks, this looks good at the Android package level. I left a comment about the wrapper API in the app-facing package, which we should remove. I apparently picked the worst example to point you to without realizing it :(
Unfortunately the implementation-package-specific APIs are still relatively new territory in our plugin development, so things aren't as consistent as they could be yet.
tarrinneal
marked this pull request as ready for review
March 8, 2023 01:15
tarrinneal
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 9, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 9, 2023
8 of 10 tasks
nploi
pushed a commit
to nploi/packages
that referenced
this pull request
Jul 16, 2023
[image_picker] moves Android 13 image picker to options
Ruhdee
added a commit
to Ruhdee/zulip-flutter
that referenced
this pull request
May 30, 2026
Fixes zulip#1490. This change sets 'ImagePickerAndroid.useAndroidPhotoPicker' to true so that 'pickMultipleMedia' shows a media-only gallery instead of a general file browser on certain Android versions, which allowed the user to pick non-media files. The package leaves this off by default to preserve access to cloud providers via the legacy picker. See: https://flutter/packages#3370 For details regarding affected Android versions, see: https://pub.dev/packages/image_picker_android flutter/packages#11320
Ruhdee
added a commit
to Ruhdee/zulip-flutter
that referenced
this pull request
Jun 1, 2026
Fixes zulip#1490. This change sets 'ImagePickerAndroid.useAndroidPhotoPicker' to true so that 'pickMultipleMedia' shows a media-only gallery instead of a general file browser on certain Android versions, which allowed the user to pick non-media files. The package leaves this off by default to preserve access to cloud providers via the legacy picker. See: https://flutter/packages#3370 For details regarding affected Android versions, see: https://pub.dev/packages/image_picker_android flutter/packages#11320
Ruhdee
added a commit
to Ruhdee/zulip-flutter
that referenced
this pull request
Jun 1, 2026
Fixes zulip#1490. This change sets 'ImagePickerAndroid.useAndroidPhotoPicker' to true so that 'pickMultipleMedia' shows a photo and video-only gallery instead of a general file browser on certain Android versions, which allowed the user to pick non-media files. The package leaves this off by default to preserve access to cloud providers via the legacy picker. See: flutter/packages#3370 For details regarding behavior according to Android version, see: https://pub.dev/packages/image_picker_android flutter/packages#11320
Ruhdee
added a commit
to Ruhdee/zulip-flutter
that referenced
this pull request
Jun 1, 2026
Fixes zulip#1490. This change sets 'ImagePickerAndroid.useAndroidPhotoPicker' to true so that 'pickMultipleMedia' shows a photo and video-only gallery instead of a general file browser on certain Android versions, which allowed the user to pick non-media files. The package leaves this off by default to preserve access to cloud providers via the legacy picker. See: flutter/packages#3370 For details regarding behavior according to Android version, see: https://pub.dev/packages/image_picker_android flutter/packages#11320
Ruhdee
added a commit
to Ruhdee/zulip-flutter
that referenced
this pull request
Jun 1, 2026
Fixes zulip#1490. This change sets 'ImagePickerAndroid.useAndroidPhotoPicker' to true so that 'pickMultipleMedia' shows a photo and video-only gallery instead of a general file browser on certain Android versions, which allowed the user to pick non-media files. The package leaves this off by default to preserve access to cloud providers via the legacy picker. See: flutter/packages#3370 For details regarding behavior according to Android version, see: https://pub.dev/packages/image_picker_android flutter/packages#11320
Ruhdee
added a commit
to Ruhdee/zulip-flutter
that referenced
this pull request
Jun 5, 2026
Fixes zulip#1490. This change sets 'ImagePickerAndroid.useAndroidPhotoPicker' to true so that 'pickMultipleMedia' shows a photo and video-only gallery instead of a general file browser on certain Android versions, which allowed the user to pick non-media files. The package leaves this off by default to preserve access to cloud providers via the legacy picker. See: flutter/packages#3370 For details regarding behavior according to Android version, see: https://pub.dev/packages/image_picker_android flutter/packages#11320
Ruhdee
added a commit
to Ruhdee/zulip-flutter
that referenced
this pull request
Jun 5, 2026
Fixes zulip#1490. This change sets 'ImagePickerAndroid.useAndroidPhotoPicker' to true so that 'pickMultipleMedia' shows a photo and video-only gallery instead of a general file browser on certain Android versions, which allowed the user to pick non-media files. The package leaves this off by default to preserve access to cloud providers via the legacy picker. See: flutter/packages#3370 For details regarding behaviour according to Android version, see: https://pub.dev/packages/image_picker_android flutter/packages#11320
Ruhdee
added a commit
to Ruhdee/zulip-flutter
that referenced
this pull request
Jun 5, 2026
Fixes zulip#1490. This change sets 'ImagePickerAndroid.useAndroidPhotoPicker' to true so that 'pickMultipleMedia' shows a photo and video-only gallery instead of a general file browser on certain Android versions, which allowed the user to pick non-media files. The package leaves this off by default to preserve access to cloud providers via the legacy picker. See: flutter/packages#3370 For details regarding behavior according to Android version, see: https://pub.dev/packages/image_picker_android flutter/packages#11320
Ruhdee
added a commit
to Ruhdee/zulip-flutter
that referenced
this pull request
Jun 6, 2026
Fixes zulip#1490. This change sets 'ImagePickerAndroid.useAndroidPhotoPicker' to true so that 'pickMultipleMedia' shows a photo and video-only gallery instead of a general file browser on certain Android versions, which allowed the user to pick non-media files. The package leaves this off by default to preserve access to cloud providers via the legacy picker. See: flutter/packages#3370 For details regarding behavior according to Android version, see: https://pub.dev/packages/image_picker_android flutter/packages#11320
Ruhdee
added a commit
to Ruhdee/zulip-flutter
that referenced
this pull request
Jun 6, 2026
Fixes zulip#1490. This change sets 'ImagePickerAndroid.useAndroidPhotoPicker' to true so that 'pickMultipleMedia' shows a photo and video-only gallery instead of a general file browser on certain Android versions, which allowed the user to pick non-media files. The package leaves this off by default to preserve access to cloud providers via the legacy picker. See: flutter/packages#3370 For details regarding behavior according to Android version, see: https://pub.dev/packages/image_picker_android flutter/packages#11320
creatorpiyush
pushed a commit
to creatorpiyush/packages
that referenced
this pull request
Jun 10, 2026
[image_picker] moves Android 13 image picker to options
bisor0627
pushed a commit
to bisor0627/packages
that referenced
this pull request
Jun 19, 2026
[image_picker] moves Android 13 image picker to options
Ruhdee
added a commit
to Ruhdee/zulip-flutter
that referenced
this pull request
Jun 19, 2026
Fixes zulip#1490. This change sets 'ImagePickerAndroid.useAndroidPhotoPicker' to true so that 'pickMultipleMedia' shows a photo and video-only gallery instead of a general file browser on certain Android versions, which allowed the user to pick non-media files. The package leaves this off by default to preserve access to cloud providers via the legacy picker. See: flutter/packages#3370 For details regarding behavior according to Android version, see: https://pub.dev/packages/image_picker_android flutter/packages#11320
Ruhdee
added a commit
to Ruhdee/zulip-flutter
that referenced
this pull request
Jun 19, 2026
Fixes zulip#1490. This change sets 'ImagePickerAndroid.useAndroidPhotoPicker' to true so that 'pickMultipleMedia' shows a photo and video-only gallery instead of a general file browser on certain Android versions, which allowed the user to pick non-media files. The package leaves this off by default to preserve access to cloud providers via the legacy picker. See: flutter/packages#3370 For details regarding behavior according to Android version, see: https://pub.dev/packages/image_picker_android flutter/packages#11320
Ruhdee
added a commit
to Ruhdee/zulip-flutter
that referenced
this pull request
Jun 28, 2026
Fixes zulip#1490. This change sets 'ImagePickerAndroid.useAndroidPhotoPicker' to true so that 'pickMultipleMedia' shows a photo and video-only gallery instead of a general file browser on certain Android versions, which allowed the user to pick non-media files. The package leaves this off by default to preserve access to cloud providers via the legacy picker. See: flutter/packages#3370 For details regarding behavior according to Android version, see: https://pub.dev/packages/image_picker_android flutter/packages#11320
Ruhdee
added a commit
to Ruhdee/zulip-flutter
that referenced
this pull request
Jul 4, 2026
Fixes zulip#1490. This change sets 'ImagePickerAndroid.useAndroidPhotoPicker' to true so that 'pickMultipleMedia' shows a photo and video-only gallery instead of a general file browser on certain Android versions, which allowed the user to pick non-media files. The package leaves this off by default to preserve access to cloud providers via the legacy picker. See: flutter/packages#3370 For details regarding behavior according to Android version, see: https://pub.dev/packages/image_picker_android flutter/packages#11320
Ruhdee
added a commit
to Ruhdee/zulip-flutter
that referenced
this pull request
Jul 4, 2026
Fixes zulip#1490. This change sets 'ImagePickerAndroid.useAndroidPhotoPicker' to true so that 'pickMultipleMedia' shows a photo and video-only gallery instead of a general file browser on certain Android versions, which allowed the user to pick non-media files. The package leaves this off by default to preserve access to cloud providers via the legacy picker. See: flutter/packages#3370 For details regarding behavior according to Android version, see: https://pub.dev/packages/image_picker_android flutter/packages#11320
Ruhdee
added a commit
to Ruhdee/zulip-flutter
that referenced
this pull request
Jul 9, 2026
Fixes zulip#1490. This change sets 'ImagePickerAndroid.useAndroidPhotoPicker' to true so that 'pickMultipleMedia' shows a photo and video-only gallery instead of a general file browser on certain Android versions, which allowed the user to pick non-media files. The package leaves this off by default to preserve access to cloud providers via the legacy picker. See: flutter/packages#3370 For details regarding behavior according to Android version, see: https://pub.dev/packages/image_picker_android flutter/packages#11320
Ruhdee
added a commit
to Ruhdee/zulip-flutter
that referenced
this pull request
Jul 9, 2026
Fixes zulip#1490. This change sets 'ImagePickerAndroid.useAndroidPhotoPicker' to true so that 'pickMultipleMedia' shows a photo and video-only gallery instead of a general file browser on certain Android versions, which allowed the user to pick non-media files. The package leaves this off by default to preserve access to cloud providers via the legacy picker. See: flutter/packages#3370 For details regarding behavior according to Android version, see: https://pub.dev/packages/image_picker_android flutter/packages#11320
Ruhdee
added a commit
to Ruhdee/zulip-flutter
that referenced
this pull request
Jul 10, 2026
Fixes zulip#1490. This change sets 'ImagePickerAndroid.useAndroidPhotoPicker' to true so that 'pickMultipleMedia' shows a photo and video-only gallery instead of a general file browser on certain Android versions, which allowed the user to pick non-media files. The package leaves this off by default to preserve access to cloud providers via the legacy picker. See: flutter/packages#3370 For details regarding behavior according to Android version, see: https://pub.dev/packages/image_picker_android flutter/packages#11320
chrisbobbe
pushed a commit
to Ruhdee/zulip-flutter
that referenced
this pull request
Jul 10, 2026
Fixes zulip#1490. This change sets 'ImagePickerAndroid.useAndroidPhotoPicker' to true so that 'pickMultipleMedia' shows a photo and video-only gallery instead of a general file browser on certain Android versions, which allowed the user to pick non-media files. The package leaves this off by default to preserve access to cloud providers via the legacy picker. See: flutter/packages#3370 For details regarding behavior according to Android version, see: https://pub.dev/packages/image_picker_android flutter/packages#11320
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the newest Android image picker doesn't yet support cloud files, I've moved it to an optional parameter for now.
This will allow users to maintain their cloud access while still allowing the people who want to use the new picker to do so as well.
fixes flutter/flutter#121744
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.