Skip to content

Add pubsub#subscription, pubsub#subscribe and pubsub#getSubscriptions #605

Description

@ryanseys

Add pubsub#subscription and pubsub#subscribe and pubsub#getSubscriptions.

All the logic I feel should move to these requests and then topic#subscription and topic#subscribe and topic#getSubscriptions should either be removed or rely on the pubsub version with an optional topic field automatically passed in.

How's this sound @stephenplusplus?

Reference: #487

/cc @tmatsuo

Activity

  1. changed the title [-]Add pubsub#subscription and pubsub#subscribe[/-] [+]Add pubsub#subscription, pubsub#subscribe and pubsub#getSubscriptions[/+] on May 17, 2015
  2. jgeewax commented on May 18, 2015

    @jgeewax
    Contributor

    Can we clarify the use case on this ? #487 is long, so it'd be nice if the description said "why" we're doing this.

    I have one outstanding question, which if answered, makes me OK with these new pubsub-level methods. I also would agree that if we do add these, the topic-level ones simply wrap the pubsub-level ones. That is:

    Topic.prototype.subscribe = function(...) {
      return this.path.to.pubsubInstance.subscribe(...);
    };
  3. ryanseys commented on May 19, 2015

    @ryanseys
    ContributorAuthor

    The use case is for creating a subscription in one project that subscribes to a topic in another project.

  4. stephenplusplus commented on May 20, 2015

    @stephenplusplus
    Contributor

    @ryanseys SGTM. In fact, I can start working on this now, but feel free to stop me if you already had this in the works.

  5. ryanseys commented on May 20, 2015

    @ryanseys
    ContributorAuthor

    @stephenplusplus You can go for it!

  6. added a commit that references this issue on Nov 11, 2022
  7. 7 remaining items

  8. added a commit that references this issue on Feb 5, 2026
  9. added a commit that references this issue on Feb 23, 2026
  10. added a commit that references this issue on Feb 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

api: pubsubIssues related to the Pub/Sub API.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions