Repository navigation
bigtable/table/createReadStream: allow early ending - #2276
Closed
stephenplusplus wants to merge 1 commit into
Closed
stephenplusplus wants to merge 1 commit into
stephenplusplus wants to merge 1 commit into
Conversation
googlebot
added
the
cla: yes
Contributor
Author
|
That doesn't seem right, @coveralls. |
callmehiphop
reviewed
May 5, 2017
callmehiphop
left a comment
callmehiphop
left a comment
Contributor
There was a problem hiding this comment.
This LGTM - do we also need to do this in sampleRowKeys?
Contributor
Author
|
This is turning out to be a bit of a problem. Marking as |
jgeewax
reviewed
May 15, 2017
| TABLE.getRows(function(err, rows) { | ||
| assert.ifError(err); | ||
| assert.strictEqual(rows.length, 4); | ||
| assert(rows.length >= ROWS.length); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
stephenplusplus
removed
the
cla: yes
Contributor
Author
|
Carried on in googleapis/nodejs-bigtable#18 |
sofisl
pushed a commit
that referenced
this pull request
Feb 24, 2026
* fix: close default BulkWriter upon terminate. * fix test * fix test
sofisl
pushed a commit
that referenced
this pull request
Feb 26, 2026
* chore: update owlbot-nodejs dependencies * Update container_test.yaml Source-Link: https://togithub.com/googleapis/synthtool/commit/1e798e6de27c63a88a1768c2a5f73b85e1523a21 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:c7e4968cfc97a204a4b2381f3ecb55cabc40c4cccf88b1ef8bef0d976be87fee
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2271