Repository navigation
Fix #6 - Allow early ending table/createReadStream - #18
Conversation
Fixed data transformation stream to stop processing data on `end` event Still, need to fix GRPC stream closing.
googlebot
added
the
cla: yes
|
To fix GRPC stream ending need to call File Ref: common-grpc/src/service.js:L398 |
|
This should fix issue #6 |
|
This looks good to me. @stephenplusplus, what do you think? |
|
I think work is still pending on the PR, judging from the comment and this line in the initial post:
|
|
GRPC stream ending need to fix in common-grpc/src/service.js:L398. I will create pull request in |
| it('should end stream early', function(done) { | ||
| var rows = []; | ||
|
|
||
| TABLE.createReadStream() |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Sorry, I misunderstood. The fix looks good, but I left one edit request for the test. |
- Insert rows and test test for early ending
Codecov Report
@@ Coverage Diff @@
## master #18 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 8 8
Lines 811 814 +3
=====================================
+ Hits 811 814 +3
Continue to review full report at Codecov.
|
|
Thanks! |
ghost
removed
the
cla: yes
* all in one * removed not related changes * fix not exported func * linter * pr fixes * renamed stuff * pr fixes * pr fixes 2 * pr fixes 3 and linter * fix ci * pr fixes 4 * pr fixes 5 * added error clause in protobufreadertransformer * added _final on bufferTransformer * tests for _flush
* all in one * removed not related changes * fix not exported func * linter * pr fixes * renamed stuff * pr fixes * pr fixes 2 * pr fixes 3 and linter * fix ci * pr fixes 4 * pr fixes 5 * added error clause in protobufreadertransformer * added _final on bufferTransformer * tests for _flush feat: add prepareQuery functionality (googleapis#21) * prepareQuery implementation with state machine protos src src2 state machine first test state machine tested added almost all tests tests done updated protos fixed tests changes to byteBuffer checksum calculation cleanup rm old code organized imports docstrings * update protos related files * some fixes fixed expired plan error matching fix create caller stream fix protobufreadertransformer not clearing buffer * linter * pr fixes * linter * pr fixes 2 * remove obsolete comment * extra test for stateMachine reset the generated code to the current main version linter update update testproxy proto testproxy support executeQuery testproxy lint linter testproxy fixes deadlines fix don't set proto format fix tests fix thrown error in executeQueryStateMachine system-test pr fixes 1 map can contain nulls system test working linter align tests after updating protos renamed prepareQuery to prepareStatement linter rest of rename fixes
5 participants
Fixed data transformation stream to stop processing data on
endeventStill, need to fix GRPC stream closing.
Fixes #6