Skip to content
This repository was archived by the owner on Mar 26, 2026. It is now read-only.

Fix#10 Implement read-rows-acceptance-test - #21

Closed
ajaaym wants to merge 17 commits into
googleapis:masterfrom
ajaaym:acceptancetest3
Closed

ajaaym wants to merge 17 commits into
googleapis:masterfrom
ajaaym:acceptancetest3

Conversation

@ajaaym

@ajaaym ajaaym commented Dec 14, 2017 •

Copy link
Copy Markdown
Contributor

Fixes #10 Implement read-rows-acceptance-test

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@ghost ghost added the cla: yes This human has signed the Contributor License Agreement. label Dec 14, 2017
@codecov-io

codecov-io commented Dec 14, 2017 •

Copy link
Copy Markdown

Codecov Report

Merging #21 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #21    +/-   ##
======================================
  Coverage     100%   100%            
======================================
  Files           8      9     +1     
  Lines         814    929   +115     
======================================
+ Hits          814    929   +115
Impacted Files Coverage Δ
src/table.js 100% <100%> (ø) ⬆️
src/chunkformatter.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfe42dd...6f4d8b8. Read the comment docs.

@ajaaym

ajaaym commented Dec 17, 2017

Copy link
Copy Markdown
Contributor Author

Closing this, will create new pull request with single commit to keep commit log clean and also stopping chunk processing loop for stream end.

@ajaaym ajaaym closed this Dec 17, 2017
@ghost ghost removed the cla: yes This human has signed the Contributor License Agreement. label Dec 17, 2017
kboroszko added a commit to kboroszko/nodejs-bigtable that referenced this pull request Jun 5, 2025
* prepareQuery implementation with state machine

protos

src

src2

state machine

first test

state machine tested

added almost all tests

tests done

updated protos

fixed tests

changes to byteBuffer

checksum calculation

cleanup

rm old code

organized imports

docstrings

* update protos related files

* some fixes
fixed expired plan error matching
fix create caller stream
fix protobufreadertransformer not clearing buffer

* linter

* pr fixes

* linter

* pr fixes 2

* remove obsolete comment

* extra test for stateMachine
kboroszko added a commit to Unoperate/nodejs-bigtable-fork that referenced this pull request Jun 5, 2025
* all in one

* removed not related changes

* fix not exported func

* linter

* pr fixes

* renamed stuff

* pr fixes

* pr fixes 2

* pr fixes 3 and linter

* fix ci

* pr fixes 4

* pr fixes 5

* added error clause in protobufreadertransformer

* added _final on bufferTransformer

* tests for _flush

feat: add prepareQuery functionality (googleapis#21)

* prepareQuery implementation with state machine

protos

src

src2

state machine

first test

state machine tested

added almost all tests

tests done

updated protos

fixed tests

changes to byteBuffer

checksum calculation

cleanup

rm old code

organized imports

docstrings

* update protos related files

* some fixes
fixed expired plan error matching
fix create caller stream
fix protobufreadertransformer not clearing buffer

* linter

* pr fixes

* linter

* pr fixes 2

* remove obsolete comment

* extra test for stateMachine

reset the generated code to the current main version

linter update

update testproxy proto

testproxy support executeQuery

testproxy lint

linter

testproxy fixes

deadlines fix

don't set proto format

fix tests

fix thrown error in executeQueryStateMachine

system-test

pr fixes 1

map can contain nulls

system test working

linter

align tests after updating protos

renamed prepareQuery to prepareStatement

linter

rest of rename

fixes
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants