Repository navigation
chore(lint): exempt generated GAPIC files from promise/prefer-const rules - #9429
Merged
Merged
Conversation
…ules Generated clients and gapic_*.ts tests lost their per-package 'root: true' eslintrc in #8266, so root promise/* + gts rules now break every regen PR.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the .eslintrc.json configuration to disable specific ESLint rules, such as promise-related rules and prefer-const, for generated GAPIC surfaces and their unit tests. This prevents linting issues on code that cannot be hand-edited. No review comments were provided, so there is no additional feedback to address.
This was referenced Sep 23, 2026
danieljbruce
pushed a commit
that referenced
this pull request
Sep 29, 2026
…ules (#9429) Generated GAPIC clients (`packages/*/src/v*/`) and their `gapic_*.ts` tests lost their per-package `root: true` eslintrc in #8266, so the root config's `plugin:promise/recommended` + gts rules now fail every regeneration PR (e.g. #9427, 59 errors). Adds an override turning off `promise/always-return`, `promise/catch-or-return`, `@typescript-eslint/no-floating-promises`, and `prefer-const` for those paths — mirroring the existing `handwritten/firestore` GAPIC override.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated GAPIC clients (
packages/*/src/v*/) and theirgapic_*.tstests lost their per-packageroot: trueeslintrc in #8266, so the root config'splugin:promise/recommended+ gts rules now fail every regeneration PR (e.g. #9427, 59 errors).Adds an override turning off
promise/always-return,promise/catch-or-return,@typescript-eslint/no-floating-promises, andprefer-constfor those paths — mirroring the existinghandwritten/firestoreGAPIC override.