Skip to content

GFQL/Cypher: audit and broaden cuDF coverage for temporal comparisons #1446

Closed

Description

@lmeyerov

Summary

Follow-up from #1374 / #1442. The Temporal7 pandas regression table is broad, while the cuDF path added in #1442 is a focused smoke using a cuDF-backed graph. Audit the GFQL/Cypher temporal comparison coverage and broaden cuDF coverage where it is likely to catch engine-specific regressions.

Scope

  • Reuse or factor the Temporal7 comparison case data so selected cases can run against both pandas and cuDF-backed graphs.
  • Cover a bounded representative set across date, time, and datetime comparisons.
  • Include literal-vs-constructor equality cases where cuDF execution may diverge from pandas.
  • Audit nearby GFQL/Cypher regression tests for pandas-only coverage of engine-sensitive behavior.
  • Keep runtime bounded; prefer a curated cuDF subset over blindly duplicating every pandas parametrized case.

Acceptance criteria

  • New or refactored tests prove the selected cases run on actual cuDF-backed DataFrames, not merely inside a RAPIDS image.
  • DGX validation is recorded for RAPIDS 25.02 and 26.02.
  • Existing pandas temporal comparison coverage remains intact.
  • The changelog records the coverage/audit improvement if code changes land.

Notes

#1442 already validated one cuDF-backed temporal comparison on DGX RAPIDS 25.02 and 26.02. This issue is for broader coverage symmetry and audit follow-through, not a blocker for #1442.

Activity

  1. lmeyerov commented on May 15, 2026

    @lmeyerov
    ContributorAuthor

    Receipt after merge of #1447:\n\n- Broadened GFQL/Cypher temporal comparison coverage on real cuDF-backed graph inputs.\n- Shared the Temporal7 comparison case data between pandas and cuDF tests.\n- Added cuDF coverage for Temporal7 comparison cases plus date/time/datetime literal-vs-constructor equality cases.\n- Added pandas/cuDF row-property temporal ORDER BY coverage for date, time, and datetime node columns.\n- Validation recorded: local focused temporal suite passed; DGX RAPIDS 25.02 and 26.02 focused cuDF targets passed with 19 tests each; review skill converged; PR CI green after rerunning stale tck-gfql against the corrected external baseline.\n\nMeta trackers updated: #1353 and #992 now mark #1446 complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions