Skip to content

GFQL/Cypher: temporal wrong-row follow-up (11 remaining, #1353 item #2) #1374

Description

@lmeyerov

Summary

Follow-up tranche under #1353 item #2 to close the remaining 11 expressions/temporal wrong-row scenarios after #1361/#1365 landed.

Context

Remaining wrong-row keys (11)

  • expr-temporal2-6-5
  • expr-temporal7-1-1
  • expr-temporal7-1-2
  • expr-temporal7-2-1
  • expr-temporal7-2-2
  • expr-temporal7-3-1
  • expr-temporal7-3-2
  • expr-temporal7-4-1
  • expr-temporal7-4-2
  • expr-temporal7-5-1
  • expr-temporal7-5-2

Acceptance criteria

  • All 11 keys move from success_wrong_rows to success_matches_expected.
  • No regressions in direct-cypher xfail contract (no increase in unexpected_success_expected_error).
  • pandas + cuDF paths remain green.

Suggested first checks

  1. Isolate shared root cause cluster in expr-temporal7-* comparison semantics.
  2. Compare temporal compare-path normalization vs build_temporal_sort_columns sort-path normalization.
  3. Add focused regressions in graphistry/tests/compute/gfql/cypher/test_lowering.py and row-level helpers where appropriate.

Activity

  1. lmeyerov commented on May 9, 2026

    @lmeyerov
    ContributorAuthor

    Cross-link: tck-gfql #38 landed via merged PR #40 (graphistry/tck-gfql#40), so Temporal7 expected-row placeholder artifacts are no longer confounding this lane.\n\nThis issue should now be treated as pure pygraphistry temporal semantics follow-up.

  2. lmeyerov commented on May 15, 2026

    @lmeyerov
    ContributorAuthor

    Merged completion receipt for #1374.

    Landed:

    Validation receipts:

    • Local temporal focused suites passed.
    • Review skill converged after 3 waves.
    • pygraphistry PR CI green after rerunning tck-gfql against the same-named tck branch.
    • tck-gfql companion PR CI green.
    • DGX RAPIDS focused cuDF validation passed on both 25.02 and 26.02.

    Follow-up coverage audit filed: #1446. This is for broader cuDF coverage symmetry; it is not a blocker for this completed issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions