Repository navigation
2.6.3.4 and 2.7.0.0 #296
Description
Activity
Modules to be obsoleted:
- Network
- Network.BSD
To be obsoleted in Network.Socket:
- MkSocket
- htonl, ntohl
- getPeerCred and getPeerEid
- send, sendTo, recv, recvFrom, recvLen
- inet_addr, inet_ntoa
- isConnected, isBound, isListening, isReadable, isWritable
- aNY_PORT, iNADDR_ANY, iN6ADDR_ANY, sOMAXCONN, sOL_SOCKET, sCM_RIGHTS
- packFamily, unpackFamily, packSocketType
- SockAddrCan (done in 2.6)
Need to implement:
- getPeerCredential
- ifNameToIndex and ifIndexToName
Signature changes:
API 2.7 3.0 fdSocketSocket -> CIntSocket -> IO CIntmkSocketCInt -> Family -> SocketType -> ProtocolNumber -> SocketStatus -> IO SocketCInt -> SocketDone in 2.6.3.4:
-
Socketshould be GCed. - doc for network-uri-flag
- examples should locate in the beginning
- Do not closeFd within sendFd
-
@eborden Now epoch change has been merged into
master. So, we can proceed this issue. Do you agree with this approach?Note that some packages are still using
Network.BSDinstead ofgetAddrInfo. So, we should release 2.7.0.0 ASAP and wait for enough time to release 3.0.@kazu-yamamoto Were there other commits in the 2.7.0.0 branch that aren't present in the 2.6.0.0? Are you just going to
cherry-pickthem over?@eborden This branch is PoC for 2.6.3.4. I think this branch is read to release. Please review
This branch is PoC for 2.7.0.0 based on the ticket of this issue. Now I understand that we need steal
getPeerCredentialto deprecategetPeerCredandgetPeerEid.Should we just deprecate
mkSocketand provide a function of a different name, say,toSocket :: CInt -> Socket?@qrilka Evan is now on vacation. He will come back on 24th.
- I should back-port Unix domain #306 to 2.6.3.4 before Evan comes back.
- Optionally, I would like to resolve this: Drop
include/HsNetworkConfig.hfrom the dist #307
aa49e91 shows that
2.6does not have the bug of unix domain.@eborden Would you release 2.6.3.4? No modification is necessary. Just make a tar ball and push it to hackagedb.
For
2.7, I will do:- Rename the current
2.7to2.7-old - Create a new
2.7on the top of2.6. - Send a PR from my
poc-2.7.0.0branch.
- Rename the current
@kazu-yamamoto Will get a candidate up today. Thanks for the reminder 😄
Candidate here: http://hackage.haskell.org/package/network-2.6.3.4/candidate
Candidate published and cafe email sent: http://hackage.haskell.org/package/network-2.6.3.4
@eborden Thank you for releasing.
Close this in favor of #315.
2.7.0.0 should deprecate all APIs which exist in 2.6 but do not exist in 3.0. I would like to create a new
2.7-newbranch based on2.6and then override current2.7in the future.2.7-newshould provideSockAddrCansince2.7does not provide a mechanism to extend socket addresses.