Repository navigation
[SYCL][Matrix] Move joint_matrix's implementation to experimental::ma… - #3584
Conversation
b1a34a2 to
fd14f72
Compare
alexbatashev
left a comment
alexbatashev
left a comment
There was a problem hiding this comment.
Put on hold to let Kevin and Dounia review.
kbsmith-intel
left a comment
kbsmith-intel
left a comment
There was a problem hiding this comment.
Why are there changes other than the specific namespace changes in this PR?
Are you referring to the folder name change? Should we create two separate PRs for each of the changes? |
eh, @alexbatashev suggested that we use enable_if_t in his comments. I am ok if we change it back or keep code there. @kbsmith-intel |
| @@ -179,8 +180,8 @@ template <typename Group, typename T, size_t NumRows, size_t NumCols, | |||
| matrix_layout Layout> | |||
| struct joint_matrix< | |||
| Group, T, NumRows, NumCols, Layout, | |||
| typename std::enable_if<(NumRows <= tile_size) && | |||
There was a problem hiding this comment.
Why are these changes part of this PR? My understanding was this PR was for namespace and file-name changes specifically.
There was a problem hiding this comment.
Eh, @alexbatashev suggested that we use enable_if_t in his comments. I am ok if we change it back or keep code there.
There was a problem hiding this comment.
I think that should be handled in a separate PR. While I agree that is an improvement, it is not part of fixing the namespace and file-name issues.
There was a problem hiding this comment.
OK, I will move it into another new PR to handle it.
There was a problem hiding this comment.
I'm ok with committing as a separate PR as well
|
ping @bader |
Disable SPIR-V validation in some tests that do not pass with current
HEAD of SPIRV-Tools (cb38b234 ("spirv-opt: Add LegalizeMultidim...",
2026-02-11)) while the discussion of #3569 is ongoing.
Original commit:
KhronosGroup/SPIRV-LLVM-Translator@8189551551d2bdb
Disable SPIR-V validation in some tests that do not pass with current
HEAD of SPIRV-Tools (cb38b234 ("spirv-opt: Add LegalizeMultidim...",
2026-02-11)) while the discussion of #3569 is ongoing.
Original commit:
KhronosGroup/SPIRV-LLVM-Translator@8189551551d2bdb
5 participants
…trix namespace