Skip to content

[SYCL] Use clangxx instead of clang++ in RUN line - #3771

Merged
vladimirlaz merged 1 commit into
intel:syclfrom
romanovvlad:private/vromanov/FixRunLine
May 18, 2021
Merged

vladimirlaz merged 1 commit into
intel:syclfrom
romanovvlad:private/vromanov/FixRunLine

Conversation

@romanovvlad

Copy link
Copy Markdown
Contributor

No description provided.

@romanovvlad
romanovvlad requested a review from a team as a code owner May 17, 2021 20:39
@romanovvlad
romanovvlad requested a review from vladimirlaz May 17, 2021 20:39
@romanovvlad

Copy link
Copy Markdown
Contributor Author

"clang" can be substituted with, for example, "clang -O2". If we have "clang++" we will get "clang -O2++" which will be incorrect compilation command.

@vladimirlaz
vladimirlaz merged commit ae87657 into intel:sycl May 18, 2021
pull Bot pushed a commit to VitalyAnkh/llvm that referenced this pull request Jul 13, 2026
…nsics (intel#3771)

Fixes misuse of `FPRoundingMode` on some unsupported intrinsics which violates the OpenCL SPIR-V spec:

https://registry.khronos.org/OpenCL/specs/unified/html/OpenCL_Env.html#_rounding_modes_for_conversions

Such misuse can now be detected by `spirv-val`.

Mirrors the [same fix](llvm/llvm-project#182742) in the SPIR-V backend in LLVM.

Resolves intel#3569

Original commit:
KhronosGroup/SPIRV-LLVM-Translator@148a0b9560a8dcc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants