Add aws-lc-rs as optional rustls backend - #3883
Merged
Merged
Conversation
Contributor
|
it looks like ci is not passing on this branch, due to |
cratelyn
reviewed
Apr 25, 2025
cratelyn
previously approved these changes
Apr 25, 2025
cratelyn
reviewed
Apr 25, 2025
cratelyn
left a comment
cratelyn
left a comment
Contributor
There was a problem hiding this comment.
this looks good, besides the need to satiate cargo deny.
This has a few benefits. Primarily this gives us a reasonable path to creating FIPS-enabled builds on architectures other than x86-64, as well as a path away from using BoringSSL as a backend. Additionally, rustls has been using the aws-lc-rs library as the default backend for a little while now, so this gives us the opportunity to stay in line with the most widely used option in the ecosystem. Signed-off-by: Scott Fleener <[email protected]>
Contributor
Author
|
cargo deny should be sorted out now, wanted to make sure there were no more structural changes i had to make first. |
cratelyn
reviewed
Apr 25, 2025
cratelyn
added a commit
that referenced
this pull request
Jan 21, 2026
rustls/rustls#2827 introduced additional algorithms to the list of supported signatures in our cryptography provider. this commit adds these to the `SUPPORTED_SIG_ALGS`, introduced in #3883, which is effectively a local copy of this internal static variable. Signed-off-by: katelyn martin <[email protected]>
cratelyn
added a commit
that referenced
this pull request
Jan 22, 2026
* chore: update rustls from 0.23.35 to 0.23.36 Signed-off-by: katelyn martin <[email protected]> * chore: add P256+SHA512 and P384+SHA512 signatures rustls/rustls#2827 introduced additional algorithms to the list of supported signatures in our cryptography provider. this commit adds these to the `SUPPORTED_SIG_ALGS`, introduced in #3883, which is effectively a local copy of this internal static variable. Signed-off-by: katelyn martin <[email protected]> * chore: update rustls-webpki from 0.103.8 to 0.103.9 Signed-off-by: katelyn martin <[email protected]> * chore: update rustls-pki-types from 0.13.1 to 0.14.0 Signed-off-by: katelyn martin <[email protected]> --------- Signed-off-by: katelyn martin <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has a few benefits. Primarily this gives us a reasonable path to creating FIPS-enabled builds on architectures other than x86-64, as well as a path away from using BoringSSL as a backend.
Additionally, rustls has been using the aws-lc-rs library as the default backend for a little while now, so this gives us the opportunity to stay in line with the most widely used option in the ecosystem.