Support P256+SHA512 and P384+SHA512 signatures in certificates - #2827
Merged
Merged
Conversation
djc
approved these changes
Jan 5, 2026
Benchmark resultsInstruction countsSignificant differencesThere are no significant instruction count differences Other differencesClick to expand
Wall-timeSignificant differencesThere are no significant wall-time differences Other differencesClick to expand
Memory usageKey:
Significant differencesThere are no significant memory usage differences Additional informationCheckout details:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2827 +/- ##
=======================================
Coverage 93.92% 93.92%
=======================================
Files 99 99
Lines 21580 21597 +17
Branches 642 642
=======================================
+ Hits 20269 20286 +17
Misses 1168 1168
Partials 143 143 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Do you want to backport this to 0.23? |
cratelyn
added a commit
to linkerd/linkerd2-proxy
that referenced
this pull request
Jan 21, 2026
rustls/rustls#2827 introduced additional algorithms to the list of supported signatures in our cryptography provider. this commit adds these to the `SUPPORTED_SIG_ALGS`, introduced in #3883, which is effectively a local copy of this internal static variable. Signed-off-by: katelyn martin <[email protected]>
cratelyn
added a commit
to linkerd/linkerd2-proxy
that referenced
this pull request
Jan 22, 2026
* chore: update rustls from 0.23.35 to 0.23.36 Signed-off-by: katelyn martin <[email protected]> * chore: add P256+SHA512 and P384+SHA512 signatures rustls/rustls#2827 introduced additional algorithms to the list of supported signatures in our cryptography provider. this commit adds these to the `SUPPORTED_SIG_ALGS`, introduced in #3883, which is effectively a local copy of this internal static variable. Signed-off-by: katelyn martin <[email protected]> * chore: update rustls-webpki from 0.103.8 to 0.103.9 Signed-off-by: katelyn martin <[email protected]> * chore: update rustls-pki-types from 0.13.1 to 0.14.0 Signed-off-by: katelyn martin <[email protected]> --------- Signed-off-by: katelyn martin <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows P256+SHA512 and P384+SHA512 signatures in certificates, when using the aws-lc-rs provider.
Previously, 0.23.32 added support for these in TLS1.2 handshake signatures. This was the topic of #2661 and #2477.
Note that (eg) Mozilla's Root Store Policy disallows such certificates. However, the reported case is a private CA, though the documentation for that CA also specifies that RSA keys are to be used? It's vibe certificates all the way down.
fixes #2825