Repository navigation
Conversation
|
Thanks for the contribution. I would fully support having board configurations in the esp32 port, and probably now is a good time to introduce them. But having board configuration would be independent to the changes here, since the options introduced here must exist for a board to select them. Also the esp.flash_xxx functions, and the FLASH_xxx constants, could probably be replaced by the Partition class in #4910 . That would mean that there'd be a single place to configure the flash sizes, in partition.csv. |
|
@zrecore See #4991 for an implementation of board configs. You can override PART_SRC in mpconfigboard.mk, and the two flash variables (FLASH_USER_START, etc) can move out of the makefile and just be defined in mpconfigboard.h. (Or better, use #4910 as @dpgeorge said). I would imagine that you'd want to create a GENERIC_D2WD, and one for your board too. |
d1deb23 to
f9d9cfb
Compare
|
Ok, rebased off PR #5027 |
3163894 to
c86ce66
Compare
Updating custom partitions CSV comments Removing 404 link in comments Adjusting partitions CSV for 2MiB ESP32 devices. Storage partition is now 0xA0000 (640KiB) Adding support for ESP32-D2WD (2MiB) for issue micropython#4986 Removing 404 link in comments Adjusting partitions CSV for 2MiB ESP32 devices. Storage partition is now 0xA0000 (640KiB) Implementing boards mpconfigboard files for generic ESP32-D2WD board type Rebase off upstream master branch. Adding support for ESP32-D2WD (2MiB) for issue micropython#4986 Git rebase off upstream master. Removing 404 link in comments What is this, recursion? Attempting to rebase off upstream master. Again. Adding support for ESP32-D2WD (2MiB) for issue micropython#4986 Removing 404 link in comments Removing merge conflict junk leftovers We no longer need some of the changes once we rebase off PR micropython#5027. FLASH_USER_START and FLASH_SIZE removed. No need for gitignore modifications Removing left over edit to README Rolling back changes to modesp, updating partitions-2MiB.csv to name storage partition as vfs Undoing changes to gitignore Renaming board config for generic ESP32-D2WD
c86ce66 to
2997519
Compare
|
Thanks for rebasing, now merged in 80d37d9 |
Fix for Issue micropython#4983 - stop state machine before restarting
3 participants
See Issue #4986
This pull request attempts to support a custom flash user start address, custom flash storage partition size, and the ability to specify a partitions CSV file. By default, this setup still supports 4MiB as per usual, but if env variables are set, ESP32 chips with 2MiB built in are supported too.
Here are the custom values used to compile MicroPython for ESP32-D2WD with this code